Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1933153002: Move self-collapse checking to LayoutBlockFlow and cache it completely. (Closed)

Created:
4 years, 7 months ago by mstensho (USE GERRIT)
Modified:
4 years, 7 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move self-collapse checking to LayoutBlockFlow and cache it completely. Only block containers (that's LayoutBlockFlow in Blinquese) can have adjoining top and bottom margins, since all other LayoutBlock derivates establish some kind of formatting context (table, flexbox, etc.). Also cache self-collapsedness completely. Previously we only used the cached result if we had previously found that the entire subtree is self-collapsing. The new approach eliminates the need for "mutable" too. BUG=302024 Committed: https://crrev.com/43862543cb7622a39c6fbc7895ffe03ba5337f54 Cr-Commit-Position: refs/heads/master@{#390729}

Patch Set 1 #

Patch Set 2 : The winbots had a point. How do you like this, then, winbots? bool bitfields would probably look ev… #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -73 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBlock.h View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 2 chunks +1 line, -63 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 1 3 chunks +69 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mstensho (USE GERRIT)
4 years, 7 months ago (2016-04-29 18:23:07 UTC) #2
leviw_travelin_and_unemployed
lgtm Awesome!
4 years, 7 months ago (2016-04-29 20:06:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1933153002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1933153002/20001
4 years, 7 months ago (2016-04-29 20:07:10 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-29 20:12:08 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:28:08 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/43862543cb7622a39c6fbc7895ffe03ba5337f54
Cr-Commit-Position: refs/heads/master@{#390729}

Powered by Google App Engine
This is Rietveld 408576698