third_party/WebKit/Source/core/layout/LayoutBlock.h - Issue 1933153002: Move self-collapse checking to LayoutBlockFlow and cache it completely.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlock.h

Issue 1933153002: Move self-collapse checking to LayoutBlockFlow and cache it completely. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: The winbots had a point. How do you like this, then, winbots? bool bitfields would probably look ev… Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/layout/LayoutBlock.h

diff --git a/third_party/WebKit/Source/core/layout/LayoutBlock.h b/third_party/WebKit/Source/core/layout/LayoutBlock.h

index 073fa932968c2c09554ab31cc087a1107256f8d3..83b7b3c423b67e800faaa45ce144b47078c8d39a 100644

--- a/third_party/WebKit/Source/core/layout/LayoutBlock.h

+++ b/third_party/WebKit/Source/core/layout/LayoutBlock.h

@@ -405,8 +405,6 @@ private:

void addChildIgnoringContinuation(LayoutObject* newChild, LayoutObject* beforeChild) override;

- bool isSelfCollapsingBlock() const override;

TrackedLayoutBoxListHashSet* positionedObjectsInternal() const;

TrackedLayoutBoxListHashSet* percentHeightDescendantsInternal() const;

@@ -503,7 +501,7 @@ protected:

unsigned m_hasMarkupTruncation : 1;

unsigned m_widthAvailableToChildrenChanged : 1;

unsigned m_heightAvailableToChildrenChanged : 1;

- mutable unsigned m_hasOnlySelfCollapsingChildren : 1;

+ unsigned m_isSelfCollapsing : 1; // True if margin-before and margin-after are adjoining.

mutable unsigned m_descendantsWithFloatsMarkedForLayout : 1;

unsigned m_hasPositionedObjects : 1;

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutBlock.cpp » ('j') | no next file with comments »