Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9922)

Unified Diff: components/nacl/renderer/sandbox_isa.h

Issue 193313002: Pepper: Move GetSandboxISA() to PPB_NaCl_Private. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixes for dmichael Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/nacl/renderer/sandbox_isa.h
diff --git a/components/nacl/renderer/sandbox_isa.h b/components/nacl/renderer/sandbox_isa.h
new file mode 100644
index 0000000000000000000000000000000000000000..b448c70744da68dec1177e9876116204476b570d
--- /dev/null
+++ b/components/nacl/renderer/sandbox_isa.h
@@ -0,0 +1,24 @@
+// Copyright (c) 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Routines for determining the most appropriate NaCl executable for
+// the current CPU's architecture.
+
+#ifndef COMPONENTS_NACL_RENDERER_SANDBOX_ISA_H
+#define COMPONENTS_NACL_RENDERER_SANDBOX_ISA_H
+
+namespace nacl {
+// Returns the kind of SFI sandbox implemented by sel_ldr on this
Mark Seaborn 2014/03/12 18:24:14 "sel_ldr" -> "NaCl"
+// platform. See the implementation in sandbox_isa.cc for possible
+// values.
+//
+// This is a function of the current CPU, and OS.
+// It is not sufficient to derive the result only from build-time parameters
+// since, for example, an x86-32 browser is capable of launching a 64-bit NaCl
+// sandbox if a 64-bit sel_ldr is installed (and indeed, may only be capable of
Mark Seaborn 2014/03/12 18:24:14 Chromium doesn't use sel_ldr any more. You could
+// launching a 64-bit sandbox).
+const char* GetSandboxISA();
Mark Seaborn 2014/03/12 18:24:14 Maybe GetSandboxArch() here too?
+} // namespace nacl
+
+#endif // COMPONENTS_NACL_RENDERER_SANDBOX_ISA_H

Powered by Google App Engine
This is Rietveld 408576698