Pepper: Move GetSandboxISA() to PPB_NaCl_Private.

components/nacl/renderer/sandbox_isa.h

+// Copyright (c) 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Routines for determining the most appropriate NaCl executable for
+// the current CPU's architecture.
+
+#ifndef COMPONENTS_NACL_RENDERER_SANDBOX_ISA_H
+#define COMPONENTS_NACL_RENDERER_SANDBOX_ISA_H
+
+namespace nacl {
+// Returns the kind of SFI sandbox implemented by sel_ldr on this

[Mark Seaborn, 2014/03/12 18:24:14]

"sel_ldr" -> "NaCl"

+// platform.  See the implementation in sandbox_isa.cc for possible
+// values.
+//
+// This is a function of the current CPU, and OS.
+// It is not sufficient to derive the result only from build-time parameters
+// since, for example, an x86-32 browser is capable of launching a 64-bit NaCl
+// sandbox if a 64-bit sel_ldr is installed (and indeed, may only be capable of

[Mark Seaborn, 2014/03/12 18:24:14]

Chromium doesn't use sel_ldr any more.  You could comment about using an x86-64
sandbox when chrome.exe is 32-bit, but that will eventually change with 64-bit
Chrome, so maybe leave this part out?  Better not to put implementation details
here.

+// launching a 64-bit sandbox).
+const char* GetSandboxISA();

[Mark Seaborn, 2014/03/12 18:24:14]

Maybe GetSandboxArch() here too?

+}  // namespace nacl
+
+#endif  // COMPONENTS_NACL_RENDERER_SANDBOX_ISA_H