Pepper: Move GetSandboxISA() to PPB_NaCl_Private.

components/nacl.gyp

Index: components/nacl.gyp
diff --git a/components/nacl.gyp b/components/nacl.gyp
index 990221e48c945ef6f9bc8c37c59ed74f365ac52f..47fcda6c400b550bede31e9979ea9f18b66df997 100644
--- a/components/nacl.gyp
+++ b/components/nacl.gyp
@@ -149,6 +149,31 @@
             'nacl/renderer/trusted_plugin_channel.cc',
             'nacl/renderer/trusted_plugin_channel.h',
           ],
+          'conditions': [
+            ['target_arch=="arm"', {
+              'sources': [
+                'nacl/renderer/arch_arm/sandbox_isa.cc',
+              ],
+            }],
+            ['target_arch=="mips"', {
+              'sources': [
+                'nacl/renderer/arch_mips/sandbox_isa.cc',
+              ],
+            }],
+            ['target_arch=="ia32"', {
+              'sources': [
+                'nacl/renderer/arch_x86/sandbox_isa.cc',
+              ],
+            }],
+            ['target_arch=="x64"', {
+              'sources': [
+                'nacl/renderer/arch_x86/sandbox_isa.cc',

[dmichael (off chromium), 2014/03/10 22:49:35]

I seem to remember that these sandbox_isa files are the only things in those
arch_xxx subdirectories. What do you think of putting them all in the same
directory and suffixing them?

You could even just stick them in 1 file. We usually prefer not to rely on ifdef
too much, but these are so short & simple, that might actually be the most
readable.

Up to your discretion, though I think we can do away with the extra directories.

+              ],
+              'defines': [
+                'TARGET_ARCH_X64',

[dmichael (off chromium), 2014/03/10 22:49:35]

Can you just use ARCH_CPU_64_BITS?
https://code.google.com/p/chromium/codesearch#chromium/src/build/build_config...

+              ],
+            }],
+          ],
           'include_dirs': [
             '..',
           ],