Pepper: Move GetSandboxISA() to PPB_NaCl_Private.

components/nacl.gyp

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'chromium_code': 1,
   },
   'includes': [
     'nacl/nacl_defines.gypi',
@@ skipping 131 matching lines @@
           'target_name': 'nacl_renderer',
           'type': 'static_library',
           'sources': [
             'nacl/renderer/pnacl_translation_resource_host.cc',
             'nacl/renderer/pnacl_translation_resource_host.h',
             'nacl/renderer/ppb_nacl_private_impl.cc',
             'nacl/renderer/ppb_nacl_private_impl.h',
             'nacl/renderer/trusted_plugin_channel.cc',
             'nacl/renderer/trusted_plugin_channel.h',
           ],
+          'conditions': [
+            ['target_arch=="arm"', {
+              'sources': [
+                'nacl/renderer/arch_arm/sandbox_isa.cc',
+              ],
+            }],
+            ['target_arch=="mips"', {
+              'sources': [
+                'nacl/renderer/arch_mips/sandbox_isa.cc',
+              ],
+            }],
+            ['target_arch=="ia32"', {
+              'sources': [
+                'nacl/renderer/arch_x86/sandbox_isa.cc',
+              ],
+            }],
+            ['target_arch=="x64"', {
+              'sources': [
+                'nacl/renderer/arch_x86/sandbox_isa.cc',

[dmichael (off chromium), 2014/03/10 22:49:35]

I seem to remember that these sandbox_isa files are the only things in those
arch_xxx subdirectories. What do you think of putting them all in the same
directory and suffixing them?

You could even just stick them in 1 file. We usually prefer not to rely on ifdef
too much, but these are so short & simple, that might actually be the most
readable.

Up to your discretion, though I think we can do away with the extra directories.

+              ],
+              'defines': [
+                'TARGET_ARCH_X64',

[dmichael (off chromium), 2014/03/10 22:49:35]

Can you just use ARCH_CPU_64_BITS?
https://code.google.com/p/chromium/codesearch#chromium/src/build/build_config...

+              ],
+            }],
+          ],
           'include_dirs': [
             '..',
           ],
           'dependencies': [
             '../content/content.gyp:content_renderer',
             '../third_party/WebKit/public/blink.gyp:blink',
             '../webkit/common/webkit_common.gyp:webkit_common',
           ],
           'defines': [
             '<@(nacl_defines)',
@@ skipping 233 matching lines @@
         'nacl/common/nacl_types.h',
         'nacl/common/pnacl_types.cc',
         'nacl/common/pnacl_types.h',
       ],
       'include_dirs': [
         '..',
       ],
     },
   ]
 }