Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2564)

Unified Diff: blimp/net/browser_connection_handler.h

Issue 1933053003: Used oneof in blimp_message.proto (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added oneof to tab_control.proto and more cleanup Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/net/browser_connection_handler.h
diff --git a/blimp/net/browser_connection_handler.h b/blimp/net/browser_connection_handler.h
index df71d9b5b300aa06491b59846e9fba85e27f4750..3dd1da3d6fe03f5c50b78e1f98bc5b6c9417f1a7 100644
--- a/blimp/net/browser_connection_handler.h
+++ b/blimp/net/browser_connection_handler.h
@@ -35,14 +35,16 @@ class BLIMP_NET_EXPORT BrowserConnectionHandler
BrowserConnectionHandler();
~BrowserConnectionHandler() override;
- // Registers a message processor which will receive all messages of the |type|
- // specified. Only one handler may be added per type.
+ // Registers a message processor which will receive all messages of the
+ // |feature_case|
Kevin M 2016/05/21 00:32:05 Premature newline here
+ // specified. Only one handler may be added per feature.
// That caller must ensure |incoming_processor| remains valid while
// this object is in-use.
//
- // Returns a BlimpMessageProcessor object for sending messages of type |type|.
+ // Returns a BlimpMessageProcessor object for sending messages for a given
+ // feature.
virtual std::unique_ptr<BlimpMessageProcessor> RegisterFeature(
- BlimpMessage::Type type,
+ BlimpMessage::FeatureCase feature_case,
BlimpMessageProcessor* incoming_processor);
// ConnectionHandler implementation.

Powered by Google App Engine
This is Rietveld 408576698