Used oneof in blimp_message.proto

blimp/net/browser_connection_handler.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BLIMP_NET_BROWSER_CONNECTION_HANDLER_H_
 #define BLIMP_NET_BROWSER_CONNECTION_HANDLER_H_
 
 #include <memory>
 
 #include "base/macros.h"
@@ skipping 17 matching lines @@
 // the lifetime of the application.
 // BrowserConnectionHandler is created on the UI thread, and then used and
 // destroyed on the IO thread.
 class BLIMP_NET_EXPORT BrowserConnectionHandler
     : public ConnectionHandler,
       public ConnectionErrorObserver {
  public:
   BrowserConnectionHandler();
   ~BrowserConnectionHandler() override;
 
-  // Registers a message processor which will receive all messages of the |type|
-  // specified. Only one handler may be added per type.
+  // Registers a message processor which will receive all messages of the
+  // |feature_case|

[Kevin M, 2016/05/21 00:32:05]

Premature newline here

+  // specified. Only one handler may be added per feature.
   // That caller must ensure |incoming_processor| remains valid while
   // this object is in-use.
   //
-  // Returns a BlimpMessageProcessor object for sending messages of type |type|.
+  // Returns a BlimpMessageProcessor object for sending messages for a given
+  // feature.
   virtual std::unique_ptr<BlimpMessageProcessor> RegisterFeature(
-      BlimpMessage::Type type,
+      BlimpMessage::FeatureCase feature_case,
       BlimpMessageProcessor* incoming_processor);
 
   // ConnectionHandler implementation.
   void HandleConnection(std::unique_ptr<BlimpConnection> connection) override;
 
   // ConnectionErrorObserver implementation.
   void OnConnectionError(int error) override;
 
  private:
   void DropCurrentConnection();
@@ skipping 14 matching lines @@
 
   // Holds network resources while there is a Client connected.
   std::unique_ptr<BlimpConnection> connection_;
 
   DISALLOW_COPY_AND_ASSIGN(BrowserConnectionHandler);
 };
 
 }  // namespace blimp
 
 #endif  // BLIMP_NET_BROWSER_CONNECTION_HANDLER_H_