Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3196)

Unified Diff: blimp/net/engine_authentication_handler.cc

Issue 1933053003: Used oneof in blimp_message.proto (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added oneof to protocol_control.proto Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/net/engine_authentication_handler.cc
diff --git a/blimp/net/engine_authentication_handler.cc b/blimp/net/engine_authentication_handler.cc
index 798ac87936146d4e103a8ed6a5ea505a5090fb40..fe020083d54cca0debb14ad23222b94f9f331243 100644
--- a/blimp/net/engine_authentication_handler.cc
+++ b/blimp/net/engine_authentication_handler.cc
@@ -111,9 +111,8 @@ void Authenticator::OnConnectionError(int error) {
void Authenticator::ProcessMessage(std::unique_ptr<BlimpMessage> message,
const net::CompletionCallback& callback) {
- if (message->type() == BlimpMessage::PROTOCOL_CONTROL &&
- message->protocol_control().type() ==
- ProtocolControlMessage::START_CONNECTION) {
+ if (message->has_protocol_control() &&
Kevin M 2016/05/20 18:28:16 check cases, not has()
shaktisahu 2016/05/20 22:29:42 See my previous comments.
+ message->protocol_control().has_start_connection()) {
bool token_match =
client_token_ ==
message->protocol_control().start_connection().client_token();

Powered by Google App Engine
This is Rietveld 408576698