Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2502)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: blimp/net/thread_pipe_manager.h

Issue 1933053003: Used oneof in blimp_message.proto (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added oneof to protocol_control.proto Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« blimp/net/engine_authentication_handler.cc ('K') | « blimp/net/input_message_unittest.cc ('k') | blimp/net/thread_pipe_manager.cc » ('j') | blimp/net/thread_pipe_manager_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/net/thread_pipe_manager.h
diff --git a/blimp/net/thread_pipe_manager.h b/blimp/net/thread_pipe_manager.h
index 01ec7d3e1649cdbff41e606a53dec463bd66e68c..7bda31e72359866edf038b39bfea3ea791430a5f 100644
--- a/blimp/net/thread_pipe_manager.h
+++ b/blimp/net/thread_pipe_manager.h
@@ -39,10 +39,11 @@ class BLIMP_NET_EXPORT ThreadPipeManager {
~ThreadPipeManager();
// Registers a message processor |incoming_processor| which will receive all
- // messages of the |type| specified. Returns a BlimpMessageProcessor object
+ // messages of the |feature_case| specified. Returns a BlimpMessageProcessor
+ // object
// for sending messages of type |type|.
Kevin M 2016/05/20 18:28:16 "type"... update comment
shaktisahu 2016/05/20 22:29:42 Done.
std::unique_ptr<BlimpMessageProcessor> RegisterFeature(
- BlimpMessage::Type type,
+ BlimpMessage::FeatureCase feature_case,
BlimpMessageProcessor* incoming_processor);
private:
« blimp/net/engine_authentication_handler.cc ('K') | « blimp/net/input_message_unittest.cc ('k') | blimp/net/thread_pipe_manager.cc » ('j') | blimp/net/thread_pipe_manager_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698