Used oneof in blimp_message.proto

blimp/net/browser_connection_handler.h

Index: blimp/net/browser_connection_handler.h
diff --git a/blimp/net/browser_connection_handler.h b/blimp/net/browser_connection_handler.h
index df71d9b5b300aa06491b59846e9fba85e27f4750..9f7848c84aee72e0bb1e5bf2932aa1f3a1209c6d 100644
--- a/blimp/net/browser_connection_handler.h
+++ b/blimp/net/browser_connection_handler.h
@@ -35,14 +35,16 @@ class BLIMP_NET_EXPORT BrowserConnectionHandler
   BrowserConnectionHandler();
   ~BrowserConnectionHandler() override;
 
-  // Registers a message processor which will receive all messages of the |type|
+  // Registers a message processor which will receive all messages of the
+  // |feature_case|
   // specified. Only one handler may be added per type.

[Kevin M, 2016/05/20 18:28:16]

"type" - update documentation

[shaktisahu, 2016/05/20 22:29:42]

Done.

   // That caller must ensure |incoming_processor| remains valid while
   // this object is in-use.
   //
-  // Returns a BlimpMessageProcessor object for sending messages of type |type|.
+  // Returns a BlimpMessageProcessor object for sending messages of type

[Kevin M, 2016/05/20 18:28:16]

"of type feature_case" doesn't parse...

how about "sending messages for a given feature"?

[shaktisahu, 2016/05/20 22:29:42]

Done.

+  // |feature_case|.
   virtual std::unique_ptr<BlimpMessageProcessor> RegisterFeature(
-      BlimpMessage::Type type,
+      BlimpMessage::FeatureCase feature_case,
       BlimpMessageProcessor* incoming_processor);
 
   // ConnectionHandler implementation.