Used oneof in blimp_message.proto

blimp/net/blimp_message_output_buffer.cc

Index: blimp/net/blimp_message_output_buffer.cc
diff --git a/blimp/net/blimp_message_output_buffer.cc b/blimp/net/blimp_message_output_buffer.cc
index b5c5ec5612b0f8c0a45fe4860160369540325fda..24365eba17fce2bba8ab306ce52c8dda49b4f496 100644
--- a/blimp/net/blimp_message_output_buffer.cc
+++ b/blimp/net/blimp_message_output_buffer.cc
@@ -135,8 +135,8 @@ void BlimpMessageOutputBuffer::WriteNextMessageIfReady() {
   std::unique_ptr<BlimpMessage> message_to_write(
       new BlimpMessage(*write_buffer_.front()->message));
   DVLOG(3) << "Writing message (id="
-           << write_buffer_.front()->message->message_id()
-           << ", type=" << message_to_write->type() << ")";
+           << write_buffer_.front()->message->message_id() << ", "

[Kevin M, 2016/05/20 18:28:16]

Nit: move the message_id logging portion into the common field extractors of
logging.cc so we are just logging *message_to_write.

[shaktisahu, 2016/05/20 22:29:42]

It might be too verbose in that case. I think we don't need the id everywhere to
be printed.
This is what it prints currently
BlimpMessage type=PROTOCOL_CONTROL subtype=CHECKPOINT_ACK checkpoint_id=1221117
byte_size=20

+           << *message_to_write << ")";
 
   output_processor_->ProcessMessage(std::move(message_to_write),
                                     write_complete_cb_.callback());