Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1654)

Unified Diff: blimp/net/blimp_message_multiplexer.cc

Issue 1933053003: Used oneof in blimp_message.proto (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added oneof to protocol_control.proto Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/net/blimp_message_multiplexer.cc
diff --git a/blimp/net/blimp_message_multiplexer.cc b/blimp/net/blimp_message_multiplexer.cc
index 0e53f3ed2c6cf4d3371d66d240d0b6333add5555..f22a22dfc2f25cbbd2749dde1ee10eaa6823a025 100644
--- a/blimp/net/blimp_message_multiplexer.cc
+++ b/blimp/net/blimp_message_multiplexer.cc
@@ -6,6 +6,7 @@
#include "base/logging.h"
#include "base/memory/ptr_util.h"
+#include "blimp/common/create_blimp_message.h"
#include "blimp/common/proto/blimp_message.pb.h"
#include "blimp/net/blimp_message_processor.h"
@@ -15,7 +16,7 @@ namespace {
class MultiplexedSender : public BlimpMessageProcessor {
public:
MultiplexedSender(base::WeakPtr<BlimpMessageProcessor> output_processor,
- BlimpMessage::Type type);
+ BlimpMessage::FeatureCase type);
Kevin M 2016/05/20 18:28:16 update name
shaktisahu 2016/05/20 22:29:41 Done.
~MultiplexedSender() override;
// BlimpMessageProcessor implementation.
@@ -25,14 +26,14 @@ class MultiplexedSender : public BlimpMessageProcessor {
private:
base::WeakPtr<BlimpMessageProcessor> output_processor_;
- BlimpMessage::Type type_;
+ BlimpMessage::FeatureCase type_;
Kevin M 2016/05/20 18:28:16 update name
shaktisahu 2016/05/20 22:29:42 Done.
DISALLOW_COPY_AND_ASSIGN(MultiplexedSender);
};
MultiplexedSender::MultiplexedSender(
base::WeakPtr<BlimpMessageProcessor> output_processor,
- BlimpMessage::Type type)
+ BlimpMessage::FeatureCase type)
Kevin M 2016/05/20 18:28:16 update param name
shaktisahu 2016/05/20 22:29:42 Done.
: output_processor_(output_processor), type_(type) {}
MultiplexedSender::~MultiplexedSender() {}
@@ -40,11 +41,7 @@ MultiplexedSender::~MultiplexedSender() {}
void MultiplexedSender::ProcessMessage(
std::unique_ptr<BlimpMessage> message,
const net::CompletionCallback& callback) {
- if (message->has_type()) {
- DCHECK_EQ(type_, message->type());
- } else {
- message->set_type(type_);
- }
+ DCHECK_EQ(type_, message->feature_case());
output_processor_->ProcessMessage(std::move(message), callback);
}
@@ -57,8 +54,9 @@ BlimpMessageMultiplexer::BlimpMessageMultiplexer(
BlimpMessageMultiplexer::~BlimpMessageMultiplexer() {}
std::unique_ptr<BlimpMessageProcessor>
-BlimpMessageMultiplexer::CreateSenderForType(BlimpMessage::Type type) {
+BlimpMessageMultiplexer::CreateSenderForType(
+ BlimpMessage::FeatureCase feature_case) {
return base::WrapUnique(
- new MultiplexedSender(output_weak_factory_.GetWeakPtr(), type));
+ new MultiplexedSender(output_weak_factory_.GetWeakPtr(), feature_case));
}
} // namespace blimp

Powered by Google App Engine
This is Rietveld 408576698