blimp/net/blimp_message_checkpointer.cc - Issue 1933053003: Used oneof in blimp_message.proto

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/net/blimp_message_checkpointer.cc

Issue 1933053003: Used oneof in blimp_message.proto (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed Kevin's comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: blimp/net/blimp_message_checkpointer.cc

diff --git a/blimp/net/blimp_message_checkpointer.cc b/blimp/net/blimp_message_checkpointer.cc

index c9a20c37c6e4903e578d79fb90feac5d0304cafe..898355b51d23f54ef1abeb3bd35790ec590246a2 100644

--- a/blimp/net/blimp_message_checkpointer.cc

+++ b/blimp/net/blimp_message_checkpointer.cc

@@ -35,7 +35,7 @@ BlimpMessageCheckpointer::~BlimpMessageCheckpointer() {}

void BlimpMessageCheckpointer::ProcessMessage(

std::unique_ptr<BlimpMessage> message,

const net::CompletionCallback& callback) {

- if (message->type() == BlimpMessage::PROTOCOL_CONTROL &&

+ if (message->has_protocol_control() &&

message->protocol_control().type() ==

ProtocolControlMessage::CHECKPOINT_ACK) {

if (message->protocol_control().has_checkpoint_ack() &&