blimp/net/blimp_message_output_buffer.cc - Issue 1933053003: Used oneof in blimp_message.proto

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/net/blimp_message_output_buffer.cc

Issue 1933053003: Used oneof in blimp_message.proto (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Compared specific 'case' field into DCHECKs Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: blimp/net/blimp_message_output_buffer.cc

diff --git a/blimp/net/blimp_message_output_buffer.cc b/blimp/net/blimp_message_output_buffer.cc

index b5c5ec5612b0f8c0a45fe4860160369540325fda..24365eba17fce2bba8ab306ce52c8dda49b4f496 100644

--- a/blimp/net/blimp_message_output_buffer.cc

+++ b/blimp/net/blimp_message_output_buffer.cc

@@ -135,8 +135,8 @@ void BlimpMessageOutputBuffer::WriteNextMessageIfReady() {

std::unique_ptr<BlimpMessage> message_to_write(

new BlimpMessage(*write_buffer_.front()->message));

DVLOG(3) << "Writing message (id="

- << write_buffer_.front()->message->message_id()

- << ", type=" << message_to_write->type() << ")";

+ << write_buffer_.front()->message->message_id() << ", "

+ << *message_to_write << ")";

output_processor_->ProcessMessage(std::move(message_to_write),

write_complete_cb_.callback());