blimp/net/blimp_message_pump_unittest.cc - Issue 1933053003: Used oneof in blimp_message.proto

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/net/blimp_message_pump_unittest.cc

Issue 1933053003: Used oneof in blimp_message.proto (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Compared specific 'case' field into DCHECKs Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: blimp/net/blimp_message_pump_unittest.cc

diff --git a/blimp/net/blimp_message_pump_unittest.cc b/blimp/net/blimp_message_pump_unittest.cc

index 5511c0dde3b4e0077d5c2e1792cac151175c1751..f93270bf557de6d60e23a7838b683e0b2e33ebc8 100644

--- a/blimp/net/blimp_message_pump_unittest.cc

+++ b/blimp/net/blimp_message_pump_unittest.cc

@@ -32,8 +32,8 @@ class BlimpMessagePumpTest : public testing::Test {

public:

BlimpMessagePumpTest()

: message1_(new BlimpMessage), message2_(new BlimpMessage) {

Kevin M 2016/05/16 22:58:02 Use CreateBlimpMessage() here to create valid inpu

shaktisahu 2016/05/17 01:21:32 Done.

- message1_->set_type(BlimpMessage::INPUT);

- message2_->set_type(BlimpMessage::TAB_CONTROL);

+ message1_->mutable_input();

+ message2_->mutable_tab_control();

message_pump_.reset(new BlimpMessagePump(&reader_));

message_pump_->set_error_observer(&error_observer_);

}