Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Side by Side Diff: blimp/common/create_blimp_message.h

Issue 1933053003: Used oneof in blimp_message.proto (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BLIMP_COMMON_CREATE_BLIMP_MESSAGE_H_ 5 #ifndef BLIMP_COMMON_CREATE_BLIMP_MESSAGE_H_
6 #define BLIMP_COMMON_CREATE_BLIMP_MESSAGE_H_ 6 #define BLIMP_COMMON_CREATE_BLIMP_MESSAGE_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <memory> 10 #include <memory>
11 #include <string> 11 #include <string>
12 12
13 #include "blimp/common/blimp_common_export.h" 13 #include "blimp/common/blimp_common_export.h"
14 #include "blimp/common/proto/blimp_message.pb.h"
14 15
15 namespace blimp { 16 namespace blimp {
16 17
17 class BlimpMessage; 18 class BlimpMessage;
18 class CompositorMessage; 19 class CompositorMessage;
19 class EngineSettingsMessage; 20 class EngineSettingsMessage;
20 class ImeMessage; 21 class ImeMessage;
21 class InputMessage; 22 class InputMessage;
22 class NavigationMessage; 23 class NavigationMessage;
23 class RenderWidgetMessage; 24 class RenderWidgetMessage;
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 BLIMP_COMMON_EXPORT std::unique_ptr<BlimpMessage> CreateBlimpMessage( 60 BLIMP_COMMON_EXPORT std::unique_ptr<BlimpMessage> CreateBlimpMessage(
60 RenderWidgetMessage** render_widget_message, 61 RenderWidgetMessage** render_widget_message,
61 int target_tab_id); 62 int target_tab_id);
62 63
63 BLIMP_COMMON_EXPORT std::unique_ptr<BlimpMessage> CreateBlimpMessage( 64 BLIMP_COMMON_EXPORT std::unique_ptr<BlimpMessage> CreateBlimpMessage(
64 SizeMessage** size_message); 65 SizeMessage** size_message);
65 66
66 BLIMP_COMMON_EXPORT std::unique_ptr<BlimpMessage> CreateBlimpMessage( 67 BLIMP_COMMON_EXPORT std::unique_ptr<BlimpMessage> CreateBlimpMessage(
67 EngineSettingsMessage** engine_settings); 68 EngineSettingsMessage** engine_settings);
68 69
70 BLIMP_COMMON_EXPORT void SetBlimpMessageType(BlimpMessage* message,
Kevin M 2016/05/02 17:47:48 I don't think we should have a function like this,
shaktisahu 2016/05/16 20:19:02 See my comment in the .cc file
71 BlimpMessage::FeatureCase type);
72
69 BLIMP_COMMON_EXPORT std::unique_ptr<BlimpMessage> CreateStartConnectionMessage( 73 BLIMP_COMMON_EXPORT std::unique_ptr<BlimpMessage> CreateStartConnectionMessage(
70 const std::string& client_token, 74 const std::string& client_token,
71 int protocol_version); 75 int protocol_version);
72 76
73 BLIMP_COMMON_EXPORT std::unique_ptr<BlimpMessage> CreateCheckpointAckMessage( 77 BLIMP_COMMON_EXPORT std::unique_ptr<BlimpMessage> CreateCheckpointAckMessage(
74 int64_t checkpoint_id); 78 int64_t checkpoint_id);
75 79
76 } // namespace blimp 80 } // namespace blimp
77 81
78 #endif // BLIMP_COMMON_CREATE_BLIMP_MESSAGE_H_ 82 #endif // BLIMP_COMMON_CREATE_BLIMP_MESSAGE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698