blimp/client/feature/ime_feature.cc - Issue 1933053003: Used oneof in blimp_message.proto

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/feature/ime_feature.cc

Issue 1933053003: Used oneof in blimp_message.proto (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: blimp/client/feature/ime_feature.cc

diff --git a/blimp/client/feature/ime_feature.cc b/blimp/client/feature/ime_feature.cc

index 7795007f924969d14c0ac2bde25cc022bd4677e5..7453618991732ba8267306ce24c9231fd440d286 100644

--- a/blimp/client/feature/ime_feature.cc

+++ b/blimp/client/feature/ime_feature.cc

@@ -35,7 +35,7 @@ void ImeFeature::OnImeTextEntered(const std::string& text) {

void ImeFeature::ProcessMessage(std::unique_ptr<BlimpMessage> message,

const net::CompletionCallback& callback) {

DCHECK(!callback.is_null());

- DCHECK_EQ(BlimpMessage::IME, message->type());

+ DCHECK(message->has_ime());

Kevin M 2016/05/02 17:47:47 Check case

shaktisahu 2016/05/16 20:19:02 I agree, it gives more information. Although it lo

DCHECK(delegate_);