Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 1933053002: Use constexpr constructors of GrStencilSettings rather than hacky macro system (Closed)

Created:
4 years, 7 months ago by bsalomon
Modified:
4 years, 7 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Use constexpr constructors of GrStencilSettings rather than hacky macro system. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1933053002 Committed: https://skia.googlesource.com/skia/+/3de75da6d2cea525b0f2adadb3645b974107e4d0

Patch Set 1 #

Patch Set 2 : more #

Patch Set 3 : whitespace #

Total comments: 2

Patch Set 4 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+248 lines, -295 lines) Patch
M src/gpu/GrClipMaskManager.cpp View 1 2 3 8 chunks +36 lines, -45 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 1 chunk +11 lines, -16 lines 0 comments Download
M src/gpu/GrPathRenderer.h View 1 chunk +7 lines, -7 lines 0 comments Download
M src/gpu/GrStencil.h View 1 2 7 chunks +133 lines, -166 lines 0 comments Download
M src/gpu/GrStencil.cpp View 22 chunks +22 lines, -22 lines 0 comments Download
M src/gpu/batches/GrDefaultPathRenderer.cpp View 12 chunks +12 lines, -12 lines 0 comments Download
M src/gpu/batches/GrStencilAndCoverPathRenderer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLUtil.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/text/GrStencilAndCoverTextContext.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M tests/GLProgramsTest.cpp View 1 chunk +14 lines, -14 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1933053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1933053002/1
4 years, 7 months ago (2016-04-29 13:03:44 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot/builds/3260)
4 years, 7 months ago (2016-04-29 13:05:15 UTC) #5
bsalomon
4 years, 7 months ago (2016-04-29 14:55:52 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1933053002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1933053002/40001
4 years, 7 months ago (2016-04-29 14:56:00 UTC) #10
robertphillips
lgtm https://codereview.chromium.org/1933053002/diff/40001/src/gpu/GrClipMaskManager.cpp File src/gpu/GrClipMaskManager.cpp (right): https://codereview.chromium.org/1933053002/diff/40001/src/gpu/GrClipMaskManager.cpp#newcode832 src/gpu/GrClipMaskManager.cpp:832: if (!canDrawDirectToClip) { kDrawToStencil ?
4 years, 7 months ago (2016-04-29 15:12:08 UTC) #12
bsalomon
https://codereview.chromium.org/1933053002/diff/40001/src/gpu/GrClipMaskManager.cpp File src/gpu/GrClipMaskManager.cpp (right): https://codereview.chromium.org/1933053002/diff/40001/src/gpu/GrClipMaskManager.cpp#newcode832 src/gpu/GrClipMaskManager.cpp:832: if (!canDrawDirectToClip) { On 2016/04/29 15:12:08, robertphillips wrote: > ...
4 years, 7 months ago (2016-04-29 15:27:53 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1933053002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1933053002/60001
4 years, 7 months ago (2016-04-29 15:28:00 UTC) #16
commit-bot: I haz the power
4 years, 7 months ago (2016-04-29 15:44:19 UTC) #18
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/3de75da6d2cea525b0f2adadb3645b974107e4d0

Powered by Google App Engine
This is Rietveld 408576698