media/cast/test/utility/in_process_receiver.h - Issue 193303002: WeakPtr destruction order cleanup: media edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/cast/test/utility/in_process_receiver.h

Issue 193303002: WeakPtr destruction order cleanup: media edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/cast/test/utility/in_process_receiver.h

diff --git a/media/cast/test/utility/in_process_receiver.h b/media/cast/test/utility/in_process_receiver.h

index 57d8a8631488b890dd4d2298ea5f5b6f714c82cf..a5b13cee43c89b2253f3b34d031e0c85a408e672 100644

--- a/media/cast/test/utility/in_process_receiver.h

+++ b/media/cast/test/utility/in_process_receiver.h

@@ -101,7 +101,7 @@ class InProcessReceiver {

scoped_ptr<transport::UdpTransport> transport_;

scoped_ptr<CastReceiver> cast_receiver_;

- // For shutdown safety, this member must be last:

+ // NOTE: Weak pointers must be invalidated before all other member variables.

base::WeakPtrFactory<InProcessReceiver> weak_factory_;

DISALLOW_COPY_AND_ASSIGN(InProcessReceiver);

« no previous file with comments | « media/cast/test/sender.cc ('k') | media/cast/transport/pacing/paced_sender.h » ('j') | no next file with comments »