Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1012)

Unified Diff: media/cast/test/sender.cc

Issue 193303002: WeakPtr destruction order cleanup: media edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/cast/cast_sender_impl.h ('k') | media/cast/test/utility/in_process_receiver.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/cast/test/sender.cc
diff --git a/media/cast/test/sender.cc b/media/cast/test/sender.cc
index 10e48e8f5c6858105277c2a03930c7fac6d8bf71..9617bcd4e8a9f98989b24f77e59bf294b8d9f9c4 100644
--- a/media/cast/test/sender.cc
+++ b/media/cast/test/sender.cc
@@ -326,7 +326,11 @@ class SendProcess {
base::TimeTicks start_time_;
base::TimeTicks send_time_;
scoped_ptr<TestAudioBusFactory> audio_bus_factory_;
+
+ // NOTE: Weak pointers must be invalidated before all other member variables.
base::WeakPtrFactory<SendProcess> weak_factory_;
+
+ DISALLOW_COPY_AND_ASSIGN(SendProcess);
};
} // namespace cast
« no previous file with comments | « media/cast/cast_sender_impl.h ('k') | media/cast/test/utility/in_process_receiver.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698