media/filters/decoder_selector.h - Issue 193303002: WeakPtr destruction order cleanup: media edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/filters/decoder_selector.h

Issue 193303002: WeakPtr destruction order cleanup: media edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/filters/decoder_selector.h

diff --git a/media/filters/decoder_selector.h b/media/filters/decoder_selector.h

index aa0b8a42ed737333f070ed994ebb8bcd71d5a624..f5b6cd3d1cd825bc0854ac0fab8f4ec4c84ec3d0 100644

--- a/media/filters/decoder_selector.h

+++ b/media/filters/decoder_selector.h

@@ -92,6 +92,8 @@ class MEDIA_EXPORT DecoderSelector {

scoped_ptr<Decoder> decoder_;

scoped_ptr<DecryptingDemuxerStream> decrypted_stream_;

+ // NOTE: This must always be last so it's invalidated before other member

+ // variables might be accessed.

base::WeakPtrFactory<DecoderSelector> weak_ptr_factory_;

DISALLOW_IMPLICIT_CONSTRUCTORS(DecoderSelector);