Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2128)

Unified Diff: media/filters/audio_renderer_impl.cc

Issue 193303002: WeakPtr destruction order cleanup: media edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/audio_renderer_impl.cc
diff --git a/media/filters/audio_renderer_impl.cc b/media/filters/audio_renderer_impl.cc
index 182e1490534cca2546ce4caaca39c21eabd86d63..7db23373f29aead4e738e66170bf0455e3fafad3 100644
--- a/media/filters/audio_renderer_impl.cc
+++ b/media/filters/audio_renderer_impl.cc
@@ -43,10 +43,10 @@ AudioRendererImpl::AudioRendererImpl(
ScopedVector<AudioDecoder> decoders,
const SetDecryptorReadyCB& set_decryptor_ready_cb)
: task_runner_(task_runner),
- weak_factory_(this),
sink_(sink),
- decoder_selector_(new AudioDecoderSelector(
- task_runner, decoders.Pass(), set_decryptor_ready_cb)),
+ decoder_selector_(new AudioDecoderSelector(task_runner,
+ decoders.Pass(),
+ set_decryptor_ready_cb)),
now_cb_(base::Bind(&base::TimeTicks::Now)),
state_(kUninitialized),
sink_playing_(false),
@@ -56,8 +56,8 @@ AudioRendererImpl::AudioRendererImpl(
audio_time_buffered_(kNoTimestamp()),
current_time_(kNoTimestamp()),
underflow_disabled_(false),
- preroll_aborted_(false) {
-}
+ preroll_aborted_(false),
+ weak_factory_(this) {}
AudioRendererImpl::~AudioRendererImpl() {
// Stop() should have been called and |algorithm_| should have been destroyed.

Powered by Google App Engine
This is Rietveld 408576698