Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: media/cast/transport/transport/udp_transport.h

Issue 193303002: WeakPtr destruction order cleanup: media edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/cast/transport/transport/udp_transport.h
diff --git a/media/cast/transport/transport/udp_transport.h b/media/cast/transport/transport/udp_transport.h
index d316416dd27648e2d085327b11323cf4a65b72c1..79b10aee414153b4455ed68ce3b52040432e15dd 100644
--- a/media/cast/transport/transport/udp_transport.h
+++ b/media/cast/transport/transport/udp_transport.h
@@ -69,6 +69,9 @@ class UdpTransport : public PacketSender {
net::IPEndPoint recv_addr_;
PacketReceiverCallback packet_receiver_;
const CastTransportStatusCallback status_callback_;
+
+ // NOTE: This must always be last so it's invalidated before other member
+ // variables might be accessed.
base::WeakPtrFactory<UdpTransport> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(UdpTransport);

Powered by Google App Engine
This is Rietveld 408576698