Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: content/renderer/media/video_capture_impl_manager.h

Issue 193303002: WeakPtr destruction order cleanup: media edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/video_capture_impl_manager.h
diff --git a/content/renderer/media/video_capture_impl_manager.h b/content/renderer/media/video_capture_impl_manager.h
index 9a5e0c26472e313b91216606c0843171c4bac272..5dded7d3ed1f8346d7ac856eb12447651392399a 100644
--- a/content/renderer/media/video_capture_impl_manager.h
+++ b/content/renderer/media/video_capture_impl_manager.h
@@ -102,9 +102,12 @@ class CONTENT_EXPORT VideoCaptureImplManager {
scoped_refptr<VideoCaptureMessageFilter> filter_;
// Following two members are bound to the render thread.
- base::WeakPtrFactory<VideoCaptureImplManager> weak_factory_;
base::ThreadChecker thread_checker_;
Ami GONE FROM CHROMIUM 2014/03/10 22:02:08 This empty line distances the factory below from t
DaleCurtis 2014/03/10 23:47:46 Done.
+ // NOTE: This must always be last so it's invalidated before other member
+ // variables might be accessed.
+ base::WeakPtrFactory<VideoCaptureImplManager> weak_factory_;
+
DISALLOW_COPY_AND_ASSIGN(VideoCaptureImplManager);
};

Powered by Google App Engine
This is Rietveld 408576698