content/renderer/media/rtc_video_encoder.h - Issue 193303002: WeakPtr destruction order cleanup: media edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/rtc_video_encoder.h

Issue 193303002: WeakPtr destruction order cleanup: media edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/media/rtc_video_encoder.h

diff --git a/content/renderer/media/rtc_video_encoder.h b/content/renderer/media/rtc_video_encoder.h

index 4d27ff2f82640868a432c59362192c3e5de73d86..2d433851c8d6a6211ab2621afd3fa82107432584 100644

--- a/content/renderer/media/rtc_video_encoder.h

+++ b/content/renderer/media/rtc_video_encoder.h

@@ -99,7 +99,8 @@ class CONTENT_EXPORT RTCVideoEncoder

int32_t impl_status_;

// Weak pointer factory for posting back VEA::Client notifications to

- // RTCVideoEncoder.

+ // RTCVideoEncoder. NOTE: This must always be last so it's invalidated before

+ // other member variables might be accessed.

base::WeakPtrFactory<RTCVideoEncoder> weak_this_factory_;

DISALLOW_COPY_AND_ASSIGN(RTCVideoEncoder);