components/offline_pages/background/request_coordinator.cc - Issue 1932953002: [Offline pages] Empty RequestQueue and SavePageRequest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/background/request_coordinator.cc

Issue 1932953002: [Offline pages] Empty RequestQueue and SavePageRequest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adding tests, fixing bugs and updating build files Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/offline_pages/background/BUILD.gn ('k') | components/offline_pages/background/request_queue.h » ('j') | components/offline_pages/background/save_page_request.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/background/request_coordinator.cc

diff --git a/components/offline_pages/background/request_coordinator.cc b/components/offline_pages/background/request_coordinator.cc

index 1e4d25633666f742df462f8cb8cd67a28b347030..d4afb5842476b35aeab831d95011d60feb44de4a 100644

--- a/components/offline_pages/background/request_coordinator.cc

+++ b/components/offline_pages/background/request_coordinator.cc

@@ -26,7 +26,6 @@ bool RequestCoordinator::StartProcessing(

return false;

}

-void RequestCoordinator::StopProcessing() {

+void RequestCoordinator::StopProcessing() {}

Pete Williamson 2016/05/02 21:45:33 Nit - you can revert moving the close curly brace.

fgorski 2016/05/02 22:11:00 Done.

} // namespace offline_pages