Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: components/offline_pages/background/request_coordinator.cc

Issue 1932953002: [Offline pages] Empty RequestQueue and SavePageRequest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adding tests, fixing bugs and updating build files Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/offline_pages/background/request_coordinator.h" 5 #include "components/offline_pages/background/request_coordinator.h"
6 6
7 // TODO(fgorski): include file with SavePageRequest definition. 7 // TODO(fgorski): include file with SavePageRequest definition.
8 8
9 namespace offline_pages { 9 namespace offline_pages {
10 10
11 // TODO(dougarnett): How to inject Offliner factories and policy objects. 11 // TODO(dougarnett): How to inject Offliner factories and policy objects.
12 RequestCoordinator::RequestCoordinator() { 12 RequestCoordinator::RequestCoordinator() {
13 // Do setup as needed. 13 // Do setup as needed.
14 } 14 }
15 15
16 RequestCoordinator::~RequestCoordinator() { 16 RequestCoordinator::~RequestCoordinator() {
17 // Do cleanup as needed. 17 // Do cleanup as needed.
18 } 18 }
19 19
20 bool RequestCoordinator::SavePageLater(const SavePageRequest& request) { 20 bool RequestCoordinator::SavePageLater(const SavePageRequest& request) {
21 return true; 21 return true;
22 } 22 }
23 23
24 bool RequestCoordinator::StartProcessing( 24 bool RequestCoordinator::StartProcessing(
25 const ProcessingDoneCallback& callback) { 25 const ProcessingDoneCallback& callback) {
26 return false; 26 return false;
27 } 27 }
28 28
29 void RequestCoordinator::StopProcessing() { 29 void RequestCoordinator::StopProcessing() {}
Pete Williamson 2016/05/02 21:45:33 Nit - you can revert moving the close curly brace.
fgorski 2016/05/02 22:11:00 Done.
30 }
31 30
32 } // namespace offline_pages 31 } // namespace offline_pages
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698