Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Issue 1932833002: QuicStreamFactoryTest cleanup. (Closed)

Created:
4 years, 7 months ago by Bence
Modified:
4 years, 7 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

QuicStreamFactoryTest cleanup. This is some random cleanup factored out of https://crrev.com/1890683002, which should be rebased on this CL. * Remove duplicate EXPECT_FALSE(HasActiveSession) lines. * Call QuicStreamRequest::Request() with matching origin and GURL. BUG=585876 Committed: https://crrev.com/d2368ad998639230d95df5a3b9612603b098173a Cr-Commit-Position: refs/heads/master@{#390501}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M net/quic/quic_stream_factory_test.cc View 5 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Bence
Ryan: PTAL. If LGTY and trybots are happy, could you please commit? Thank you.
4 years, 7 months ago (2016-04-28 20:06:35 UTC) #2
Ryan Hamilton
lgtm Nice catch!
4 years, 7 months ago (2016-04-28 21:58:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1932833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1932833002/1
4 years, 7 months ago (2016-04-28 21:59:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-28 22:06:18 UTC) #6
Bence
On 2016/04/28 22:06:18, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) Awesome, ...
4 years, 7 months ago (2016-04-28 22:30:19 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:21:53 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d2368ad998639230d95df5a3b9612603b098173a
Cr-Commit-Position: refs/heads/master@{#390501}

Powered by Google App Engine
This is Rietveld 408576698