Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Unified Diff: net/quic/quic_stream_factory_test.cc

Issue 1932833002: QuicStreamFactoryTest cleanup. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_stream_factory_test.cc
diff --git a/net/quic/quic_stream_factory_test.cc b/net/quic/quic_stream_factory_test.cc
index fb4997718db4f4405ba85e64076fd1ac95d29825..496bd302df058a928e2451732bcda78b83c4d1fb 100644
--- a/net/quic/quic_stream_factory_test.cc
+++ b/net/quic/quic_stream_factory_test.cc
@@ -1103,7 +1103,6 @@ TEST_P(QuicStreamFactoryTest, Goaway) {
EXPECT_EQ(true,
QuicStreamFactoryPeer::IsLiveSession(factory_.get(), session));
EXPECT_FALSE(HasActiveSession(host_port_pair_));
- EXPECT_FALSE(HasActiveSession(host_port_pair_));
// Create a new request for the same destination and verify that a
// new session is created.
@@ -2805,8 +2804,8 @@ TEST_P(QuicStreamFactoryTest, BadPacketLoss) {
TestCompletionCallback callback2;
QuicStreamRequest request2(factory_.get());
EXPECT_EQ(OK, request2.Request(server2, privacy_mode_,
- /*cert_verify_flags=*/0, url_, "GET", net_log_,
- callback2.callback()));
+ /*cert_verify_flags=*/0, url2_, "GET",
+ net_log_, callback2.callback()));
QuicChromiumClientSession* session2 = GetActiveSession(server2);
// If there is no packet loss during handshake confirmation, number of lossy
@@ -2858,7 +2857,6 @@ TEST_P(QuicStreamFactoryTest, BadPacketLoss) {
EXPECT_TRUE(
QuicStreamFactoryPeer::IsQuicDisabled(factory_.get(), server3.port()));
EXPECT_FALSE(HasActiveSession(server3));
- EXPECT_FALSE(HasActiveSession(server3));
// Set packet_loss_rate to higher value than packet_loss_threshold 3rd time in
// a row and IsQuicDisabled() should close the session.
@@ -2870,7 +2868,6 @@ TEST_P(QuicStreamFactoryTest, BadPacketLoss) {
EXPECT_TRUE(
QuicStreamFactoryPeer::IsQuicDisabled(factory_.get(), server4.port()));
EXPECT_FALSE(HasActiveSession(server4));
- EXPECT_FALSE(HasActiveSession(server4));
std::unique_ptr<QuicHttpStream> stream = request.CreateStream();
EXPECT_TRUE(stream.get());
@@ -3150,7 +3147,7 @@ TEST_P(QuicStreamFactoryTest, PublicResetPostHandshakeTwoOfThree) {
TestCompletionCallback callback3;
QuicStreamRequest request3(factory_.get());
EXPECT_EQ(OK, request3.Request(server3, privacy_mode_,
- /*cert_verify_flags=*/0, url2_, "GET",
+ /*cert_verify_flags=*/0, url3_, "GET",
net_log_, callback3.callback()));
QuicChromiumClientSession* session3 = GetActiveSession(server3);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698