Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issue 1932713002: Remove RefCountedGarbageCollected<> GC plugin handling. (Closed)

Created:
4 years, 7 months ago by sof
Modified:
4 years, 7 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove RefCountedGarbageCollected<> GC plugin handling. The RefCountedGarbageCollected<> transition type is no longer used and has been removed. Follow up and retire the GC plugin's checks for it. R=haraken BUG=604481 Committed: https://crrev.com/4fb24d3a331557fc94e556beb24ecbb34fb60330 Cr-Commit-Position: refs/heads/master@{#390421}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -30 lines) Patch
M tools/clang/blink_gc_plugin/CheckFieldsVisitor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tools/clang/blink_gc_plugin/Config.h View 1 chunk +1 line, -8 lines 0 comments Download
M tools/clang/blink_gc_plugin/RecordInfo.h View 1 chunk +0 lines, -1 line 0 comments Download
M tools/clang/blink_gc_plugin/RecordInfo.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/ref_ptr_to_gc_managed_class.h View 1 chunk +0 lines, -8 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/ref_ptr_to_gc_managed_class.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
sof
please take a look.
4 years, 7 months ago (2016-04-28 13:12:08 UTC) #3
haraken
LGTM
4 years, 7 months ago (2016-04-28 14:10:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1932713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1932713002/1
4 years, 7 months ago (2016-04-28 17:37:56 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-04-28 18:12:37 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-04-30 17:19:34 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4fb24d3a331557fc94e556beb24ecbb34fb60330
Cr-Commit-Position: refs/heads/master@{#390421}

Powered by Google App Engine
This is Rietveld 408576698