tools/clang/blink_gc_plugin/CheckFieldsVisitor.cpp - Issue 1932713002: Remove RefCountedGarbageCollected<> GC plugin handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/CheckFieldsVisitor.cpp

Issue 1932713002: Remove RefCountedGarbageCollected<> GC plugin handling. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/clang/blink_gc_plugin/CheckFieldsVisitor.cpp

diff --git a/tools/clang/blink_gc_plugin/CheckFieldsVisitor.cpp b/tools/clang/blink_gc_plugin/CheckFieldsVisitor.cpp

index e609a9706d58f7375c8897dd3cc40683772c0336..e5d69f0b897c0a13e8b0b0cbdc2b544632b38272 100644

--- a/tools/clang/blink_gc_plugin/CheckFieldsVisitor.cpp

+++ b/tools/clang/blink_gc_plugin/CheckFieldsVisitor.cpp

@@ -86,7 +86,7 @@ void CheckFieldsVisitor::AtValue(Value* edge) {

// Disallow OwnPtr<T>, RefPtr<T> and T* to stack-allocated types.

if (Parent()->IsOwnPtr() ||

- (Parent()->IsRefPtr() && !edge->value()->IsGCRefCounted()) ||

+ Parent()->IsRefPtr() ||

(stack_allocated_host_ && Parent()->IsRawPtr())) {

invalid_fields_.push_back(std::make_pair(

current_, InvalidSmartPtr(Parent())));

« no previous file with comments | « no previous file | tools/clang/blink_gc_plugin/Config.h » ('j') | no next file with comments »