Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1932703002:
[build] Fix empty action inputs for xcode-ninja builds (Closed)
|
Created:
4 years, 7 months ago by Michael Achenbach Modified:
4 years, 7 months ago CC:
v8-reviews_googlegroups.com, Yang Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[build] Fix empty action inputs for xcode-ninja builds
BUG=chromium:606898
LOG=n
Committed: https://crrev.com/e7e7124c835e4600f1ca0d1b9518b6b1c74123bb
Cr-Commit-Position: refs/heads/master@{#35860}
Patch Set 1 #
Messages
Total messages: 18 (7 generated)
Description was changed from ========== [build] Fix empty action inputs for xcode-ninja builds BUG= ========== to ========== [build] Fix empty action inputs for xcode-ninja builds BUG=chromium:606898 LOG=n ==========
machenbach@chromium.org changed reviewers: + jochen@chromium.org, thakis@chromium.org, vogelheim@chromium.org
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1932703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1932703002/1
PTAL xcode attempts to add a file for each input item of an action. If the file is an empty string it adds ../src as a file, not as a dir. When then more sources are added from ../src/*, an assertion fires as src is not a dir. This had been like that all the time, but when v8.gyp was in the tools/gyp dir, it didn't matter as there are no further sources in that dir. After moving it to src, this flushed out.
lgtm
On 2016/04/28 12:18:03, Michael Achenbach wrote: > This had been like that all the time, but when v8.gyp was in the tools/gyp dir, > it didn't matter as there are no further sources in that dir. After moving it to > src, this flushed out. Probably doesn't matter, but the embed_script/warmup_script thing was added only rather recently. So, for small values of "all the time".. :)
The CQ bit was unchecked by machenbach@chromium.org
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1932703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1932703002/1
lgtm
Tested that new bot fails with the problem before this lands: https://build.chromium.org/p/client.v8/builders/V8%20Mac64%20-%20xcode/builds...
Tested that new bot fails with the problem before this lands: https://build.chromium.org/p/client.v8/builders/V8%20Mac64%20-%20xcode/builds...
Message was sent while issue was closed.
Description was changed from ========== [build] Fix empty action inputs for xcode-ninja builds BUG=chromium:606898 LOG=n ========== to ========== [build] Fix empty action inputs for xcode-ninja builds BUG=chromium:606898 LOG=n ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Bot passes after this landed: https://build.chromium.org/p/client.v8/builders/V8%20Mac64%20-%20xcode/builds...
Message was sent while issue was closed.
Description was changed from ========== [build] Fix empty action inputs for xcode-ninja builds BUG=chromium:606898 LOG=n ========== to ========== [build] Fix empty action inputs for xcode-ninja builds BUG=chromium:606898 LOG=n Committed: https://crrev.com/e7e7124c835e4600f1ca0d1b9518b6b1c74123bb Cr-Commit-Position: refs/heads/master@{#35860} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/e7e7124c835e4600f1ca0d1b9518b6b1c74123bb Cr-Commit-Position: refs/heads/master@{#35860} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
