Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1220)

Unified Diff: src/v8.gyp

Issue 1932703002: [build] Fix empty action inputs for xcode-ninja builds (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/v8.gyp
diff --git a/src/v8.gyp b/src/v8.gyp
index 9f1a2542185e928c3ec13b789ecafd9d9644e176..402ca72b2dba89cd6bf907c7baf3483291f6a98d 100644
--- a/src/v8.gyp
+++ b/src/v8.gyp
@@ -192,8 +192,18 @@
'action_name': 'run_mksnapshot',
'inputs': [
'<(mksnapshot_exec)',
- '<(embed_script)',
- '<(warmup_script)',
+ ],
+ 'conditions': [
+ ['embed_script!=""', {
+ 'inputs': [
+ '<(embed_script)',
+ ],
+ }],
+ ['warmup_script!=""', {
+ 'inputs': [
+ '<(warmup_script)',
+ ],
+ }],
],
'outputs': [
'<(INTERMEDIATE_DIR)/snapshot.cc',
@@ -299,8 +309,6 @@
'action_name': 'run_mksnapshot (external)',
'inputs': [
'<(mksnapshot_exec)',
- '<(embed_script)',
- '<(warmup_script)',
],
'variables': {
'mksnapshot_flags': [],
@@ -314,6 +322,16 @@
],
},
'conditions': [
+ ['embed_script!=""', {
+ 'inputs': [
+ '<(embed_script)',
+ ],
+ }],
+ ['warmup_script!=""', {
+ 'inputs': [
+ '<(warmup_script)',
+ ],
+ }],
['want_separate_host_toolset==1', {
'target_conditions': [
['_toolset=="host"', {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698