Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3080)

Unified Diff: ash/shelf/shelf_button.h

Issue 1932433002: Update activity indicator from a light bar to a point (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add MaterialDesignController and address comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/shelf/shelf_button.cc » ('j') | ash/shelf/shelf_button.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/shelf/shelf_button.h
diff --git a/ash/shelf/shelf_button.h b/ash/shelf/shelf_button.h
index 4a84a61a532d502bb5d7a60e0047ef4beea274a6..c59153bf35e1004b011392be2aa94ebe5691a24c 100644
--- a/ash/shelf/shelf_button.h
+++ b/ash/shelf/shelf_button.h
@@ -90,6 +90,9 @@ class ASH_EXPORT ShelfButton : public views::CustomButton {
// Updates the status bar (bitmap, orientation, visibility).
void UpdateBar();
+ // Creates an activity indicator image.
+ void GetIndicatorImage(gfx::Canvas& canvas);
tdanderson 2016/05/02 17:58:35 nit: I would prefer this be called something like
varkha 2016/05/02 18:13:59 Or maybe PaintIndicatorOnCanvas to self-document t
yiyix 2016/05/03 18:55:34 I agree. I changed it to PaintIndicatorOnCanvas, i
+
// The shelf view hosting this button.
ShelfView* shelf_view_;
« no previous file with comments | « no previous file | ash/shelf/shelf_button.cc » ('j') | ash/shelf/shelf_button.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698