Update activity indicator from a light bar to a point

ash/shelf/shelf_button.h

 // Copyright 2013 The Chromium Authors. All rights reserved.

[tdanderson, 2016/05/02 17:58:35]

nit: Remove "BUG=595007" from the CL title.

nit: Include a brief CL description explaining what your CL is doing, and be
sure to mention that this change is being landed behind an experimental flag for
CrOS MD.

 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ASH_SHELF_SHELF_BUTTON_H_
 #define ASH_SHELF_SHELF_BUTTON_H_
 
 #include "ash/ash_export.h"
 #include "base/macros.h"
 #include "ui/gfx/shadow_value.h"
 #include "ui/views/controls/button/custom_button.h"
@@ skipping 71 matching lines @@
  private:
   class BarView;
 
   // Updates the parts of the button to reflect the current |state_| and
   // alignment. This may add or remove views, layout and paint.
   void UpdateState();
 
   // Updates the status bar (bitmap, orientation, visibility).
   void UpdateBar();
 
+  // Creates an activity indicator image.
+  void GetIndicatorImage(gfx::Canvas& canvas);

[tdanderson, 2016/05/02 17:58:35]

nit: I would prefer this be called something like "PaintIndicatorImage" instead.
Starting the function name with "Get" is misleading since it isn't returning
anything.

[varkha, 2016/05/02 18:13:59]

Or maybe PaintIndicatorOnCanvas to self-document the parameter.

[yiyix, 2016/05/03 18:55:34]

I agree. I changed it to PaintIndicatorOnCanvas, i found this name is more
descriptive.

+
   // The shelf view hosting this button.
   ShelfView* shelf_view_;
 
   // The icon part of a button can be animated independently of the rest.
   views::ImageView* icon_view_;
 
   // Draws a bar underneath the image to represent the state of the application.
   BarView* bar_;
 
   // The current application state, a bitfield of State enum values.
   int state_;
 
   gfx::ShadowValues icon_shadows_;
 
   // If non-null the destuctor sets this to true. This is set while the menu is
   // showing and used to detect if the menu was deleted while running.
   bool* destroyed_flag_;
 
   DISALLOW_COPY_AND_ASSIGN(ShelfButton);
 };
 
 }  // namespace ash
 
 #endif  // ASH_SHELF_SHELF_BUTTON_H_