Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1932403002: MD User Manager: Removes external style sheets in Polymer components (Closed)

Created:
4 years, 7 months ago by Moe
Modified:
4 years, 6 months ago
CC:
arv+watch_chromium.org, chromium-reviews, michaelpg+watch-md-ui_chromium.org, pam+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

External Style Sheets are deprecated in Polymer. BUG=563722 Committed: https://crrev.com/c09d6d23ebe2c95ccfb589dd0f5077caed7664fd Cr-Commit-Position: refs/heads/master@{#391352}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+418 lines, -456 lines) Patch
M chrome/browser/browser_resources.grd View 2 chunks +0 lines, -5 lines 0 comments Download
D chrome/browser/resources/md_user_manager/control_bar.css View 1 chunk +0 lines, -37 lines 0 comments Download
M chrome/browser/resources/md_user_manager/control_bar.html View 1 chunk +35 lines, -4 lines 0 comments Download
D chrome/browser/resources/md_user_manager/create_profile.css View 1 chunk +0 lines, -163 lines 0 comments Download
M chrome/browser/resources/md_user_manager/create_profile.html View 1 chunk +161 lines, -3 lines 0 comments Download
D chrome/browser/resources/md_user_manager/supervised_user_learn_more.css View 1 chunk +0 lines, -56 lines 0 comments Download
M chrome/browser/resources/md_user_manager/supervised_user_learn_more.html View 1 chunk +54 lines, -3 lines 0 comments Download
D chrome/browser/resources/md_user_manager/user_manager_pages.css View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/browser/resources/md_user_manager/user_manager_pages.html View 1 chunk +10 lines, -2 lines 0 comments Download
D chrome/browser/resources/md_user_manager/user_manager_tutorial.css View 1 chunk +0 lines, -160 lines 0 comments Download
M chrome/browser/resources/md_user_manager/user_manager_tutorial.html View 1 chunk +158 lines, -3 lines 1 comment Download
M chrome/browser/ui/webui/signin/md_user_manager_ui.cc View 3 chunks +0 lines, -8 lines 0 comments Download

Dependent Patchsets:

Issue 1916913010 Patch 1
Issue 1939933002 Patch 1
Issue 1939933002 Patch 60001
Issue 1939933002 Patch 80001
Issue 1939933002 Patch 100001
Issue 1939933002 Patch 120001

Messages

Total messages: 28 (13 generated)
Moe
Hi demetrios, Please review this CL.
4 years, 7 months ago (2016-04-29 20:52:17 UTC) #3
dpapad
lgtm
4 years, 7 months ago (2016-04-29 21:13:59 UTC) #4
Moe
Thank you!
4 years, 7 months ago (2016-04-29 21:16:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1932403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1932403002/1
4 years, 7 months ago (2016-04-29 21:16:52 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/175542)
4 years, 7 months ago (2016-04-29 21:26:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1932403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1932403002/1
4 years, 7 months ago (2016-05-02 15:22:26 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/175981)
4 years, 7 months ago (2016-05-02 15:28:52 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1932403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1932403002/1
4 years, 7 months ago (2016-05-03 18:35:22 UTC) #15
Moe
Hi Roger, this patch is removing some resources in: chrome/browser/ui/webui/signin/md_user_manager_ui.cc Please take a look. Thank ...
4 years, 7 months ago (2016-05-03 18:37:27 UTC) #18
Roger Tawa OOO till Jul 10th
lgtm
4 years, 7 months ago (2016-05-03 19:32:49 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1932403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1932403002/1
4 years, 7 months ago (2016-05-03 20:41:21 UTC) #21
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-03 20:45:44 UTC) #23
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c09d6d23ebe2c95ccfb589dd0f5077caed7664fd Cr-Commit-Position: refs/heads/master@{#391352}
4 years, 7 months ago (2016-05-03 20:48:23 UTC) #25
Dan Beam
https://codereview.chromium.org/1932403002/diff/1/chrome/browser/resources/md_user_manager/user_manager_tutorial.html File chrome/browser/resources/md_user_manager/user_manager_tutorial.html (right): https://codereview.chromium.org/1932403002/diff/1/chrome/browser/resources/md_user_manager/user_manager_tutorial.html#newcode78 chrome/browser/resources/md_user_manager/user_manager_tutorial.html:78: color: var(--google-grey-600); google-grey-600 doesn't exist, did you mean paper-grey-600?
4 years, 7 months ago (2016-05-26 23:41:03 UTC) #27
Moe
4 years, 6 months ago (2016-05-27 13:49:15 UTC) #28
Message was sent while issue was closed. 
On 2016/05/26 23:41:03, Dan Beam wrote:
>
https://codereview.chromium.org/1932403002/diff/1/chrome/browser/resources/md...
> File chrome/browser/resources/md_user_manager/user_manager_tutorial.html
> (right):
> 
>
https://codereview.chromium.org/1932403002/diff/1/chrome/browser/resources/md...
> chrome/browser/resources/md_user_manager/user_manager_tutorial.html:78: color:
> var(--google-grey-600);
> google-grey-600 doesn't exist, did you mean paper-grey-600?

I Addressed this in https://codereview.chromium.org/2016073002/
Thank you!

Powered by Google App Engine
This is Rietveld 408576698