Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Issue 1916913010: MD User Manager: latest design change, css refactoring, accessiblity, and bug fixes (Closed)

Created:
4 years, 7 months ago by Moe
Modified:
4 years, 7 months ago
Reviewers:
tommycli
CC:
chromium-reviews, michaelpg+watch-md-ui_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@md-user-manager-stylesheets
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

This patch includes a set of changes, improvements, and bug fixes for the MD User Manager: 1. When there are no signed in users available, a message containing a link to a HC article is displayed. 2. Bug fix related to the button action bar collapsing when creating a new profile and browsing as guest were disabled. 3. Bug fix related to user pod shadow while focused and the pod's re-auth warning. 4. Refactors css into shared_styles.html 6. Addresses accessibility issues with action buttons, links, import-supervised-user dialog, and profile avatar icons. 7. Replaces instances of i18n-content with $i18n{}. 8. Updates browser tests accordingly. 9. Fixes unnecessary scrollbar seen on User manager Window. 10. Fixes the ripple effect for 'Select an account' dropdown. BUG=563722, 607845, 604326, 605087

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+254 lines, -285 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_user_manager/control_bar.html View 1 chunk +13 lines, -28 lines 0 comments Download
M chrome/browser/resources/md_user_manager/create_profile.html View 6 chunks +72 lines, -87 lines 0 comments Download
M chrome/browser/resources/md_user_manager/create_profile.js View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/resources/md_user_manager/import_supervised_user.html View 4 chunks +59 lines, -59 lines 0 comments Download
M chrome/browser/resources/md_user_manager/import_supervised_user.js View 1 chunk +0 lines, -14 lines 0 comments Download
M chrome/browser/resources/md_user_manager/shared_styles.html View 1 chunk +49 lines, -1 line 0 comments Download
M chrome/browser/resources/md_user_manager/supervised_user_create_confirm.html View 4 chunks +7 lines, -25 lines 0 comments Download
M chrome/browser/resources/md_user_manager/supervised_user_learn_more.html View 3 chunks +5 lines, -19 lines 0 comments Download
M chrome/browser/resources/md_user_manager/user_manager.html View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/resources/md_user_manager/user_manager_pages.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/md_user_manager/user_manager_styles.html View 5 chunks +6 lines, -15 lines 0 comments Download
M chrome/browser/resources/md_user_manager/user_manager_tutorial.html View 7 chunks +14 lines, -20 lines 0 comments Download
M chrome/browser/resources/md_user_manager/user_manager_tutorial.js View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/signin/signin_create_profile_handler.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/test/data/webui/md_user_manager/create_profile_tests.js View 2 chunks +11 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (5 generated)
Moe
Hi Tommy, Please review this CL. Thank you.
4 years, 7 months ago (2016-04-29 22:01:09 UTC) #3
tommycli
4 years, 7 months ago (2016-05-02 17:18:56 UTC) #7
Hi Moe,

Would it be possible to split this CL into one patch per bug? It would make the
review process much faster.


Thanks,

Tommy

Powered by Google App Engine
This is Rietveld 408576698