Deprecate KeyboardEvent.keyIdentifier

Deprecate KeyboardEvent.keyIdentifier

Deprecate the keyIdentifier field see:
https://www.chromestatus.com/features/5316065118650368

Intent to Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/fqnFyoDCOaA/s4WIxZPqAAAJ

BUG=607349
Committed: https://crrev.com/ed99b4d4aa6d128426053d0532ad082312010b0a
Cr-Commit-Position: refs/heads/master@{#391020}

[dtapuska, 2016-04-29 17:29:05]

Description was changed from

==========
Deprecate KeyboardEvent.keyIdentifier

Deprecate the keyIdentifier field see:
https://www.chromestatus.com/features/5316065118650368

Intent to Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/fqnFyoDCOaA/s4WIxZPq...

BUG=607349
==========

to

==========
Deprecate KeyboardEvent.keyIdentifier

Deprecate the keyIdentifier field see:
https://www.chromestatus.com/features/5316065118650368

Intent to Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/fqnFyoDCOaA/s4WIxZPq...

BUG=607349
==========

[dtapuska, 2016-04-29 17:29:05]

dtapuska@chromium.org changed reviewers:
+ bokan@chromium.org

[bokan, 2016-04-29 17:38:54]

https://codereview.chromium.org/1932293002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/Deprecation.cpp (right):

https://codereview.chromium.org/1932293002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/Deprecation.cpp:371: return
willBeRemoved("'KeyboardEvent.keyIdentifier'", 53, "5316065118650368");
I'm assuming the last argument should be the URL to details on chromestatus?

[dtapuska, 2016-04-29 17:41:13]

https://codereview.chromium.org/1932293002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/Deprecation.cpp (right):

https://codereview.chromium.org/1932293002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/Deprecation.cpp:371: return
willBeRemoved("'KeyboardEvent.keyIdentifier'", 53, "5316065118650368");
see the sprintf here:

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

[bokan, 2016-04-29 17:42:54]

On 2016/04/29 17:41:13, dtapuska wrote:
>
https://codereview.chromium.org/1932293002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/frame/Deprecation.cpp (right):
> 
>
https://codereview.chromium.org/1932293002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/frame/Deprecation.cpp:371: return
> willBeRemoved("'KeyboardEvent.keyIdentifier'", 53, "5316065118650368");
> see the sprintf here:
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

Got it, lgtm

Does this mean UseCounter::TouchDragUserGestureUsedCrossOrigin above is wrong?

[dtapuska, 2016-04-29 17:49:47]

On 2016/04/29 17:42:54, bokan wrote:
> On 2016/04/29 17:41:13, dtapuska wrote:
> >
>
https://codereview.chromium.org/1932293002/diff/1/third_party/WebKit/Source/c...
> > File third_party/WebKit/Source/core/frame/Deprecation.cpp (right):
> > 
> >
>
https://codereview.chromium.org/1932293002/diff/1/third_party/WebKit/Source/c...
> > third_party/WebKit/Source/core/frame/Deprecation.cpp:371: return
> > willBeRemoved("'KeyboardEvent.keyIdentifier'", 53, "5316065118650368");
> > see the sprintf here:
> > 
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...
> 
> Got it, lgtm
> 
> Does this mean UseCounter::TouchDragUserGestureUsedCrossOrigin above is wrong?

Yup posted change https://codereview.chromium.org/1933833002/ to fix that. blame
blame's rbyers :-)

[dtapuska, 2016-04-29 17:54:10]

The CQ bit was checked by dtapuska@chromium.org

[commit-bot: I haz the power, 2016-04-29 17:54:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1932293002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1932293002/1

[commit-bot: I haz the power, 2016-04-29 18:52:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-29 18:52:04]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[dtapuska, 2016-05-02 19:03:13]

The CQ bit was checked by dtapuska@chromium.org

[dtapuska, 2016-05-02 19:03:13]

The patchset sent to the CQ was uploaded after l-g-t-m from bokan@chromium.org
Link to the patchset: https://codereview.chromium.org/1932293002/#ps20001
(title: "Adjust layout tests")

[commit-bot: I haz the power, 2016-05-02 19:03:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1932293002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1932293002/20001

[commit-bot: I haz the power, 2016-05-02 19:09:55]

Description was changed from

==========
Deprecate KeyboardEvent.keyIdentifier

Deprecate the keyIdentifier field see:
https://www.chromestatus.com/features/5316065118650368

Intent to Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/fqnFyoDCOaA/s4WIxZPq...

BUG=607349
==========

to

==========
Deprecate KeyboardEvent.keyIdentifier

Deprecate the keyIdentifier field see:
https://www.chromestatus.com/features/5316065118650368

Intent to Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/fqnFyoDCOaA/s4WIxZPq...

BUG=607349
==========

[commit-bot: I haz the power, 2016-05-02 19:09:56]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-02 19:11:13]

Description was changed from

==========
Deprecate KeyboardEvent.keyIdentifier

Deprecate the keyIdentifier field see:
https://www.chromestatus.com/features/5316065118650368

Intent to Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/fqnFyoDCOaA/s4WIxZPq...

BUG=607349
==========

to

==========
Deprecate KeyboardEvent.keyIdentifier

Deprecate the keyIdentifier field see:
https://www.chromestatus.com/features/5316065118650368

Intent to Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/fqnFyoDCOaA/s4WIxZPq...

BUG=607349

Committed: https://crrev.com/ed99b4d4aa6d128426053d0532ad082312010b0a
Cr-Commit-Position: refs/heads/master@{#391020}
==========

[commit-bot: I haz the power, 2016-05-02 19:11:14]

Patchset 2 (id:??) landed as
https://crrev.com/ed99b4d4aa6d128426053d0532ad082312010b0a
Cr-Commit-Position: refs/heads/master@{#391020}