src/api.cc - Issue 1932163002: Reland of move more dead code after Object.observe removal

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api.cc

Issue 1932163002: Reland of move more dead code after Object.observe removal (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: don't throw on error Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/api.cc

diff --git a/src/api.cc b/src/api.cc

index 3b1f72ebf31734d63447c54f9d9700dc8ff906bc..8214028311bc1b7dcc60cd7cabb9801f86446438 100644

--- a/src/api.cc

+++ b/src/api.cc

@@ -1792,7 +1792,7 @@ MaybeLocal<Value> Script::Run(Local<Context> context) {

i::TimerEventScope<i::TimerEventExecute> timer_scope(isolate);

TRACE_EVENT0("v8", "V8.Execute");

auto fun = i::Handle<i::JSFunction>::cast(Utils::OpenHandle(this));

- i::Handle<i::Object> receiver(isolate->global_proxy(), isolate);

+ i::Handle<i::Object> receiver = isolate->global_proxy();

Local<Value> result;

has_pending_exception =

!ToLocal<Value>(i::Execution::Call(isolate, fun, receiver, 0, NULL),

« no previous file with comments | « no previous file | src/bootstrapper.cc » ('j') | no next file with comments »