Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 1932013002: swarming: fix include_performance_stats param (Closed)

Created:
4 years, 7 months ago by nodir
Modified:
4 years, 7 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Base URL:
https://chromium.googlesource.com/external/github.com/luci/luci-py@master
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

swarming: fix include_performance_stats param The swarming.task.result endpoint method uses a message with include_performance_stats field, however the HTTP method is GET so there is no way to pass it. Change it from message field to resource container field. R=maruel@chromium.org BUG= Committed: https://github.com/luci/luci-py/commit/1d9e2421b6d4334c1af99df878119e3f57df708c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -8 lines) Patch
M appengine/swarming/handlers_endpoints.py View 1 chunk +3 lines, -2 lines 0 comments Download
M appengine/swarming/swarming_rpcs.py View 1 chunk +0 lines, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (5 generated)
nodir
PTAL
4 years, 7 months ago (2016-04-28 20:33:52 UTC) #2
M-A Ruel
Ugh, lgtm
4 years, 7 months ago (2016-04-28 21:02:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1932013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1932013002/1
4 years, 7 months ago (2016-04-28 21:07:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Luci-py Presubmit on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Luci-py%20Presubmit/builds/754)
4 years, 7 months ago (2016-04-28 21:12:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1932013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1932013002/1
4 years, 7 months ago (2016-04-29 18:07:29 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-04-29 18:10:26 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-py/commit/1d9e2421b6d4334c1af99df878119e3f57df708c

Powered by Google App Engine
This is Rietveld 408576698