Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1925343002: swarming: IsolatedOperation -> OperationStats (Closed)

Created:
4 years, 7 months ago by nodir
Modified:
4 years, 7 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Base URL:
https://chromium.googlesource.com/external/github.com/luci/luci-py@master
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

swarming: IsolatedOperation -> OperationStats Rename IsolatedOperation to OperationStats because it will be used for CIPD operations too. The change is backward compatible. R=maruel@chromium.org BUG=601022 Committed: https://github.com/luci/luci-py/commit/1e1be248df1e615ddb71521204d7993184fa58cd

Patch Set 1 : swarming: IsolatedOperation -> OperationStats #

Total comments: 2

Patch Set 2 : update comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M appengine/swarming/handlers_bot.py View 1 chunk +2 lines, -2 lines 0 comments Download
M appengine/swarming/message_conversion.py View 1 chunk +2 lines, -2 lines 0 comments Download
M appengine/swarming/server/task_result.py View 1 3 chunks +6 lines, -6 lines 0 comments Download
M appengine/swarming/server/task_result_test.py View 1 chunk +2 lines, -2 lines 0 comments Download
M appengine/swarming/server/task_scheduler_test.py View 1 chunk +2 lines, -2 lines 0 comments Download
M appengine/swarming/swarming_rpcs.py View 2 chunks +3 lines, -3 lines 0 comments Download

Depends on Patchset:

Issue 1932013002 Patch 1

Messages

Total messages: 12 (6 generated)
nodir
PTAL. Backward compatible as demonstrated by https://2035-e0b5e05-tainted-nodir-dot-chromium-swarm-dev.appspot.com/user/task/2e774a41c39f3e10 and https://apis-explorer.appspot.com/apis-explorer/?base=https://2035-e0b5e05-tainted-nodir-dot-chromium-swarm-dev.appspot.com/_ah/api#p/swarming/v1/swarming.task.result?task_id=2e774a41c39f3e10&include_performance_stats=true&_h=4&
4 years, 7 months ago (2016-04-28 20:38:53 UTC) #2
M-A Ruel
cool! lgtm https://codereview.chromium.org/1925343002/diff/20001/appengine/swarming/server/task_result.py File appengine/swarming/server/task_result.py (right): https://codereview.chromium.org/1925343002/diff/20001/appengine/swarming/server/task_result.py#newcode251 appengine/swarming/server/task_result.py:251: """Statistics for an isolated operation. s/isolated //
4 years, 7 months ago (2016-04-28 21:03:29 UTC) #3
nodir
https://codereview.chromium.org/1925343002/diff/20001/appengine/swarming/server/task_result.py File appengine/swarming/server/task_result.py (right): https://codereview.chromium.org/1925343002/diff/20001/appengine/swarming/server/task_result.py#newcode251 appengine/swarming/server/task_result.py:251: """Statistics for an isolated operation. On 2016/04/28 21:03:29, M-A ...
4 years, 7 months ago (2016-04-28 21:10:18 UTC) #4
commit-bot: I haz the power
This CL has an open dependency (Issue 1932013002 Patch 1). Please resolve the dependency and ...
4 years, 7 months ago (2016-04-28 21:10:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1925343002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1925343002/40001
4 years, 7 months ago (2016-04-29 18:11:19 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-04-29 18:13:57 UTC) #12
Message was sent while issue was closed. 
Committed patchset #2 (id:40001) as
https://github.com/luci/luci-py/commit/1e1be248df1e615ddb71521204d7993184fa58cd

Powered by Google App Engine
This is Rietveld 408576698