If the expected 'returnType' is 'null', just do not check it.

If the expected 'returnType' is 'null', just do not check it.

The completion tests are fragile and too sensitive to task model
changes. I have a change that inserts a new analysis result between
RESOLVED_UNIT3 and RESOLVED_UNIT4, and by doing this the next task to
perform resolves types in imported libraries. But in CC test we
continue performing analysis tasks and incidentally resolve something
what the 'null' checks don't expect.

So, I think we need to stop doing these checks.
If needed, we can check something directly by asking the state of some
analysis results from AnalysisContext.

R=jwren@google.com, danrubel@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/470c5de12e54628305ad915f463383397b24e11e

[jwren, 2016-04-28 20:13:55]

lgtm

[scheglov, 2016-04-28 20:15:37]

Description was changed from

==========
If the expected 'returnType' is 'null', just do not check it.

The completion tests are fragile and too sensitive to task model
changes. I have a change that inserts a new analysis result between
RESOLVED_UNIT3 and RESOLVED_UNIT4, and by doing this the next task to
perform resolves types in imported libraries. But in CC test we
continue performing analysis tasks and incidentally resolve something
what the 'null' checks don't expect.

So, I think we need to stop doing these checks.
If needed, we can check something directly by asking the state of some
analysis results from AnalysisContext.

R=jwren@google.com, danrubel@google.com
BUG=
==========

to

==========
If the expected 'returnType' is 'null', just do not check it.

The completion tests are fragile and too sensitive to task model
changes. I have a change that inserts a new analysis result between
RESOLVED_UNIT3 and RESOLVED_UNIT4, and by doing this the next task to
perform resolves types in imported libraries. But in CC test we
continue performing analysis tasks and incidentally resolve something
what the 'null' checks don't expect.

So, I think we need to stop doing these checks.
If needed, we can check something directly by asking the state of some
analysis results from AnalysisContext.

R=jwren@google.com, danrubel@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/470c5de12e54628305ad915f463383397b24e11e
==========

[scheglov, 2016-04-28 20:15:39]

Committed patchset #1 (id:1) manually as
470c5de12e54628305ad915f463383397b24e11e (presubmit successful).