Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Unified Diff: pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart

Issue 1932003002: If the expected 'returnType' is 'null', just do not check it. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart
diff --git a/pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart b/pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart
index dc011c1b0232b0b4ebbf0e0d7ce9f84a419dd37b..24b9aaa30be75b8914c5d1db3c2edae9f1628263 100644
--- a/pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart
+++ b/pkg/analysis_server/test/services/completion/dart/completion_contributor_util.dart
@@ -262,8 +262,6 @@ abstract class DartCompletionContributorTest extends AbstractContextTest {
expect(cs.returnType, returnType);
} else if (isNullExpectedReturnTypeConsideredDynamic) {
expect(cs.returnType, 'dynamic');
- } else {
- expect(cs.returnType, isNull);
}
protocol.Element element = cs.element;
expect(element, isNotNull);
@@ -278,8 +276,6 @@ abstract class DartCompletionContributorTest extends AbstractContextTest {
expect(element.returnType, returnType);
} else if (isNullExpectedReturnTypeConsideredDynamic) {
expect(element.returnType, 'dynamic');
- } else {
- expect(element.returnType, isNull);
}
assertHasParameterInfo(cs);
return cs;
@@ -419,8 +415,6 @@ abstract class DartCompletionContributorTest extends AbstractContextTest {
expect(cs.returnType, returnType);
} else if (isNullExpectedReturnTypeConsideredDynamic) {
expect(cs.returnType, 'dynamic');
- } else {
- expect(cs.returnType, isNull);
}
protocol.Element element = cs.element;
expect(element, isNotNull);
@@ -431,8 +425,6 @@ abstract class DartCompletionContributorTest extends AbstractContextTest {
expect(element.returnType, returnType);
} else if (isNullExpectedReturnTypeConsideredDynamic) {
expect(element.returnType, 'dynamic');
- } else {
- expect(element.returnType, isNull);
}
assertHasNoParameterInfo(cs);
return cs;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698