Repurpose Release_Developer BUILDTYPE and remove SK_DEVELOPER.

Repurpose Release_Developer BUILDTYPE and remove SK_DEVELOPER.

The Release_Developer build type is now used to build Skia with
release level optimizations but still enable SK_DEBUG. This in turn
means that SkASSERTS and SkRTConf are available in this mode.

Further we can then remove SK_DEVELOPER as a define as it is true
iff SK_DEBUG is true.
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1931903002
DOCS_PREVIEW= https://skia.org/?cl=1931903002

Committed: https://skia.googlesource.com/skia/+/efe46d20949efbc59bedd1f28e6f42a0dd069688

[djsollen, 2016-04-28 16:30:46]

Description was changed from

==========
Repurpose Release_Developer BUILDTYPE and remove SK_DEVELOPER.

The Release_Developer build type is now used to build Skia with
release level optimizations but still enable SK_DEBUG. This in turn
means that SkASSERTS and SkRTConf are available in this mode.

Further we can then remove SK_DEVELOPER as a define as it is true
iff SK_DEBUG is true.
==========

to

==========
Repurpose Release_Developer BUILDTYPE and remove SK_DEVELOPER.

The Release_Developer build type is now used to build Skia with
release level optimizations but still enable SK_DEBUG. This in turn
means that SkASSERTS and SkRTConf are available in this mode.

Further we can then remove SK_DEVELOPER as a define as it is true
iff SK_DEBUG is true.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
DOCS_PREVIEW= https://skia.org/?cl=1931903002
==========

[djsollen, 2016-04-28 18:02:33]

djsollen@google.com changed reviewers:
+ mtklein@google.com, reed@google.com, stephana@google.com

[djsollen, 2016-04-28 18:03:01]

The CQ bit was checked by djsollen@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-28 18:03:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1931903002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1931903002/1

[commit-bot: I haz the power, 2016-04-28 18:23:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-28 18:23:02]

Dry run: This issue passed the CQ dry run.

[djsollen, 2016-04-28 20:42:27]

ptal.  I passes the ASAN trybot so it should be good to go.

[mtklein, 2016-04-28 20:46:01]

lgtm

https://codereview.chromium.org/1931903002/diff/1/src/core/SkResourceCache.cpp
File src/core/SkResourceCache.cpp (left):

https://codereview.chromium.org/1931903002/diff/1/src/core/SkResourceCache.cp...
src/core/SkResourceCache.cpp:551: // SkLazyPtr does the same sort of thing.
Ah, good.  SkLazyPtr was deleted but this comment wasn't.  Good riddance.

[djsollen, 2016-04-29 12:04:58]

The CQ bit was checked by djsollen@google.com

[commit-bot: I haz the power, 2016-04-29 12:05:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1931903002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1931903002/1

[commit-bot: I haz the power, 2016-04-29 13:41:37]

Description was changed from

==========
Repurpose Release_Developer BUILDTYPE and remove SK_DEVELOPER.

The Release_Developer build type is now used to build Skia with
release level optimizations but still enable SK_DEBUG. This in turn
means that SkASSERTS and SkRTConf are available in this mode.

Further we can then remove SK_DEVELOPER as a define as it is true
iff SK_DEBUG is true.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
DOCS_PREVIEW= https://skia.org/?cl=1931903002
==========

to

==========
Repurpose Release_Developer BUILDTYPE and remove SK_DEVELOPER.

The Release_Developer build type is now used to build Skia with
release level optimizations but still enable SK_DEBUG. This in turn
means that SkASSERTS and SkRTConf are available in this mode.

Further we can then remove SK_DEVELOPER as a define as it is true
iff SK_DEBUG is true.
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
DOCS_PREVIEW= https://skia.org/?cl=1931903002

Committed:
https://skia.googlesource.com/skia/+/efe46d20949efbc59bedd1f28e6f42a0dd069688
==========

[commit-bot: I haz the power, 2016-04-29 13:41:38]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/efe46d20949efbc59bedd1f28e6f42a0dd069688