Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: src/core/SkResourceCache.cpp

Issue 1931903002: Repurpose Release_Developer BUILDTYPE and remove SK_DEVELOPER. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/core/SkGraphics.cpp ('k') | src/core/SkStream.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/core/SkResourceCache.cpp
diff --git a/src/core/SkResourceCache.cpp b/src/core/SkResourceCache.cpp
index fa3cb9dbe0bca11e3ab983f6f6a949bcaa2a1d28..e465132288ad09e862f1aafae473ed090db35893 100644
--- a/src/core/SkResourceCache.cpp
+++ b/src/core/SkResourceCache.cpp
@@ -544,15 +544,6 @@ void SkResourceCache::checkMessages() {
SK_DECLARE_STATIC_MUTEX(gMutex);
static SkResourceCache* gResourceCache = nullptr;
-static void cleanup_gResourceCache() {
- // We'll clean this up in our own tests, but disable for clients.
- // Chrome seems to have funky multi-process things going on in unit tests that
- // makes this unsafe to delete when the main process atexit()s.
- // SkLazyPtr does the same sort of thing.
mtklein 2016/04/28 20:46:00 Ah, good. SkLazyPtr was deleted but this comment
-#if SK_DEVELOPER
- delete gResourceCache;
-#endif
-}
/** Must hold gMutex when calling. */
static SkResourceCache* get_cache() {
@@ -564,7 +555,6 @@ static SkResourceCache* get_cache() {
#else
gResourceCache = new SkResourceCache(SK_DEFAULT_IMAGE_CACHE_LIMIT);
#endif
- atexit(cleanup_gResourceCache);
}
return gResourceCache;
}
« no previous file with comments | « src/core/SkGraphics.cpp ('k') | src/core/SkStream.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698