Ship Web Push subscription restrictions

Ship Web Push subscription restrictions

This exposes the "applicationServerKey" property when subscribing with
the Push API, in which the developer can provide their application
server's key per draft-ietf-webpush-vapid.

https://tools.ietf.org/html/draft-ietf-webpush-vapid

When doing so, Chrome will give them an endpoint for the subscription
that supports the Web Push Protocol rather than the proprietary GCM
protocol. The endpoint is still provided by GCM.

Intent to Ship:

https://groups.google.com/a/chromium.org/d/topic/blink-dev/Wo7fimlUUjc/discussion

BUG=583753
Committed: https://crrev.com/f3008ae7b25404f8a5d2f4c1699abed5b0ecb1e7
Cr-Commit-Position: refs/heads/master@{#394747}

[Peter Beverloo, 2016-04-28 13:31:06]

peter@chromium.org changed reviewers:
+ harkness@chromium.org, mvanouwerkerk@chromium.org

[Peter Beverloo, 2016-04-28 13:31:07]

+harkness for review

This needs an intent to ship once I verify it with the server side :)

[harkness, 2016-04-28 15:21:13]

LGTM

https://codereview.chromium.org/1931843002/diff/1/content/browser/push_messag...
File content/browser/push_messaging/push_messaging_message_filter.cc (right):

https://codereview.chromium.org/1931843002/diff/1/content/browser/push_messag...
content/browser/push_messaging/push_messaging_message_filter.cc:85: bool
IsApplicationServerKey(const std::string& sender_info) {
So, we still allow arbitrary formatted server keys, but only using the
non-standard protocol enpoints?

https://codereview.chromium.org/1931843002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/push_messaging/application-server-key-standard-endpoint.html
(right):

https://codereview.chromium.org/1931843002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/push_messaging/application-server-key-standard-endpoint.html:12:
const PUBLIC_KEY = [
If you can reference constants in a separate .js file, you can use the
push_constants.js here instead of declaring the key again.

[Peter Beverloo, 2016-04-28 15:22:51]

https://codereview.chromium.org/1931843002/diff/1/content/browser/push_messag...
File content/browser/push_messaging/push_messaging_message_filter.cc (right):

https://codereview.chromium.org/1931843002/diff/1/content/browser/push_messag...
content/browser/push_messaging/push_messaging_message_filter.cc:85: bool
IsApplicationServerKey(const std::string& sender_info) {
On 2016/04/28 15:21:13, harkness wrote:
> So, we still allow arbitrary formatted server keys, but only using the
> non-standard protocol enpoints?

Yes.

https://codereview.chromium.org/1931843002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/http/tests/push_messaging/application-server-key-standard-endpoint.html
(right):

https://codereview.chromium.org/1931843002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/http/tests/push_messaging/application-server-key-standard-endpoint.html:12:
const PUBLIC_KEY = [
On 2016/04/28 15:21:13, harkness wrote:
> If you can reference constants in a separate .js file, you can use the
> push_constants.js here instead of declaring the key again.

This is the first layout test that uses a public key, so there's nothing here to
share it with. Unfortunately browser tests, instrumentation tests and layout
tests don't have a shared web-accessible location :(

[Michael van Ouwerkerk, 2016-04-29 17:21:21]

lgtm with nit

I have a feeling I reviewed 95% of these changes before, is this based on
another CL?

https://codereview.chromium.org/1931843002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/push_messaging/application-server-key-standard-endpoint.html
(right):

https://codereview.chromium.org/1931843002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/push_messaging/application-server-key-standard-endpoint.html:24:
async_test(function(test) {
nit: use a promise_test?

[Peter Beverloo, 2016-05-18 17:43:24]

peter@chromium.org changed reviewers:
+ avi@chromium.org, rbyers@chromium.org

[Peter Beverloo, 2016-05-18 17:43:24]

+avi for content/public/
+rbyers RuntimeEnabledFeatures.in

https://codereview.chromium.org/1931843002/diff/20001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/http/tests/push_messaging/application-server-key-standard-endpoint.html
(right):

https://codereview.chromium.org/1931843002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/http/tests/push_messaging/application-server-key-standard-endpoint.html:24:
async_test(function(test) {
On 2016/04/29 17:21:21, Michael van Ouwerkerk wrote:
> nit: use a promise_test?

Done.

[Peter Beverloo, 2016-05-18 17:43:38]

Description was changed from

==========
Ship Web Push subscription restrictions

This exposes the "applicationServerKey" property when subscribing with
the Push API, in which the developer can provide their application
server's key per draft-ietf-webpush-vapid.

https://tools.ietf.org/html/draft-ietf-webpush-vapid

When doing so, Chrome will give them an endpoint for the subscription
that supports the Web Push Protocol rather than the proprietary GCM
protocol. The endpoint is still provided by GCM.

BUG=583753
==========

to

==========
Ship Web Push subscription restrictions

This exposes the "applicationServerKey" property when subscribing with
the Push API, in which the developer can provide their application
server's key per draft-ietf-webpush-vapid.

https://tools.ietf.org/html/draft-ietf-webpush-vapid

When doing so, Chrome will give them an endpoint for the subscription
that supports the Web Push Protocol rather than the proprietary GCM
protocol. The endpoint is still provided by GCM.

Intent to Ship:

https://groups.google.com/a/chromium.org/d/topic/blink-dev/Wo7fimlUUjc/discus...

BUG=583753
==========

[Avi (use Gerrit), 2016-05-18 18:00:36]

content/public lgtm

[Rick Byers, 2016-05-18 18:09:40]

On 2016/05/18 17:43:24, Peter Beverloo wrote:
> +avi for content/public/
> +rbyers RuntimeEnabledFeatures.in

RuntimeEnabledFeatures LGTM

[Peter Beverloo, 2016-05-18 18:11:11]

The CQ bit was checked by peter@chromium.org

[Peter Beverloo, 2016-05-18 18:11:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
harkness@chromium.org, mvanouwerkerk@chromium.org
Link to the patchset: https://codereview.chromium.org/1931843002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-05-18 18:11:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1931843002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1931843002/40001

[commit-bot: I haz the power, 2016-05-18 23:18:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-18 23:18:38]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Peter Beverloo, 2016-05-18 23:44:26]

The CQ bit was checked by peter@chromium.org

[commit-bot: I haz the power, 2016-05-18 23:45:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1931843002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1931843002/40001

[commit-bot: I haz the power, 2016-05-19 05:37:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-19 05:37:43]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Peter Beverloo, 2016-05-19 11:02:04]

The CQ bit was checked by peter@chromium.org

[commit-bot: I haz the power, 2016-05-19 11:02:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1931843002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1931843002/40001

[commit-bot: I haz the power, 2016-05-19 12:28:54]

Description was changed from

==========
Ship Web Push subscription restrictions

This exposes the "applicationServerKey" property when subscribing with
the Push API, in which the developer can provide their application
server's key per draft-ietf-webpush-vapid.

https://tools.ietf.org/html/draft-ietf-webpush-vapid

When doing so, Chrome will give them an endpoint for the subscription
that supports the Web Push Protocol rather than the proprietary GCM
protocol. The endpoint is still provided by GCM.

Intent to Ship:

https://groups.google.com/a/chromium.org/d/topic/blink-dev/Wo7fimlUUjc/discus...

BUG=583753
==========

to

==========
Ship Web Push subscription restrictions

This exposes the "applicationServerKey" property when subscribing with
the Push API, in which the developer can provide their application
server's key per draft-ietf-webpush-vapid.

https://tools.ietf.org/html/draft-ietf-webpush-vapid

When doing so, Chrome will give them an endpoint for the subscription
that supports the Web Push Protocol rather than the proprietary GCM
protocol. The endpoint is still provided by GCM.

Intent to Ship:

https://groups.google.com/a/chromium.org/d/topic/blink-dev/Wo7fimlUUjc/discus...

BUG=583753
==========

[commit-bot: I haz the power, 2016-05-19 12:28:56]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-05-19 12:30:13]

Description was changed from

==========
Ship Web Push subscription restrictions

This exposes the "applicationServerKey" property when subscribing with
the Push API, in which the developer can provide their application
server's key per draft-ietf-webpush-vapid.

https://tools.ietf.org/html/draft-ietf-webpush-vapid

When doing so, Chrome will give them an endpoint for the subscription
that supports the Web Push Protocol rather than the proprietary GCM
protocol. The endpoint is still provided by GCM.

Intent to Ship:

https://groups.google.com/a/chromium.org/d/topic/blink-dev/Wo7fimlUUjc/discus...

BUG=583753
==========

to

==========
Ship Web Push subscription restrictions

This exposes the "applicationServerKey" property when subscribing with
the Push API, in which the developer can provide their application
server's key per draft-ietf-webpush-vapid.

https://tools.ietf.org/html/draft-ietf-webpush-vapid

When doing so, Chrome will give them an endpoint for the subscription
that supports the Web Push Protocol rather than the proprietary GCM
protocol. The endpoint is still provided by GCM.

Intent to Ship:

https://groups.google.com/a/chromium.org/d/topic/blink-dev/Wo7fimlUUjc/discus...

BUG=583753

Committed: https://crrev.com/f3008ae7b25404f8a5d2f4c1699abed5b0ecb1e7
Cr-Commit-Position: refs/heads/master@{#394747}
==========

[commit-bot: I haz the power, 2016-05-19 12:30:15]

Patchset 3 (id:??) landed as
https://crrev.com/f3008ae7b25404f8a5d2f4c1699abed5b0ecb1e7
Cr-Commit-Position: refs/heads/master@{#394747}