chrome/browser/push_messaging/push_messaging_service_impl.h - Issue 1931843002: Ship Web Push subscription restrictions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/push_messaging/push_messaging_service_impl.h

Issue 1931843002: Ship Web Push subscription restrictions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/push_messaging/push_messaging_service_impl.h

diff --git a/chrome/browser/push_messaging/push_messaging_service_impl.h b/chrome/browser/push_messaging/push_messaging_service_impl.h

index c0da586054e3999aa6d667ab2c86817ee29b7753..483e9a96138905a2a8a9e674d7096bb4ec6f12ec 100644

--- a/chrome/browser/push_messaging/push_messaging_service_impl.h

+++ b/chrome/browser/push_messaging/push_messaging_service_impl.h

@@ -73,7 +73,7 @@ class PushMessagingServiceImpl : public content::PushMessagingService,

bool CanHandle(const std::string& app_id) const override;

// content::PushMessagingService implementation:

- GURL GetPushEndpoint() override;

+ GURL GetEndpoint(bool standard_protocol) const override;

void SubscribeFromDocument(

const GURL& requesting_origin,

int64_t service_worker_registration_id,