Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(783)

Unified Diff: content/renderer/render_thread_impl.h

Issue 1931793002: Stop using nested message loop for alert() and other JS dialogs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: updated comment Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_thread_impl.h
diff --git a/content/renderer/render_thread_impl.h b/content/renderer/render_thread_impl.h
index 806d32bfbd261725bf64de15bf2db7ae1358d6c4..b37682a0cf5404142136ed4d86288b4b06105230 100644
--- a/content/renderer/render_thread_impl.h
+++ b/content/renderer/render_thread_impl.h
@@ -223,13 +223,6 @@ class CONTENT_EXPORT RenderThreadImpl
// time this routine returns.
scoped_refptr<gpu::GpuChannelHost> EstablishGpuChannelSync(CauseForGpuLaunch);
- // This method modifies how the next message is sent. Normally, when sending
- // a synchronous message that runs a nested message loop, we need to suspend
- // callbacks into WebKit. This involves disabling timers and deferring
- // resource loads. However, there are exceptions when we need to customize
- // the behavior.
- void DoNotNotifyWebKitOfModalLoop();
-
// True if we are running layout tests. This currently disables forwarding
// various status messages to the console, skips network error pages, and
// short circuits size update and focus events.
@@ -574,7 +567,6 @@ class CONTENT_EXPORT RenderThreadImpl
// The number of idle handler calls that skip sending idle notifications.
int idle_notifications_to_skip_;
- bool notify_webkit_of_modal_loop_;
bool webkit_shared_timer_suspended_;
// The following flag is used to control layout test specific behavior.

Powered by Google App Engine
This is Rietveld 408576698