content/renderer/render_frame_impl.h - Issue 1931793002: Stop using nested message loop for alert() and other JS dialogs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.h

Issue 1931793002: Stop using nested message loop for alert() and other JS dialogs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updated comment Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java ('k') | content/renderer/render_frame_impl.cc » ('j') | content/renderer/render_thread_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/render_frame_impl.h

diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h

index bd2b61a63b60088c756e7dc35b4a6febc70379f7..3f4df5c1395ce66a5e4d5a418789f55ba44efdbb 100644

--- a/content/renderer/render_frame_impl.h

+++ b/content/renderer/render_frame_impl.h

@@ -850,8 +850,8 @@ class CONTENT_EXPORT RenderFrameImpl

// selection handles in sync with the webpage.

void SyncSelectionIfRequired();

- // Sends a message and runs a nested message loop.

- bool SendAndRunNestedMessageLoop(IPC::SyncMessage* message);

+ // Sends a synchronous message.

+ bool SendSyncMessage(IPC::SyncMessage* message);

aelias_OOO_until_Jul13 2016/05/17 19:35:29 This declaration has no implementation nor callers

Changwan Ryu 2016/05/19 00:44:56 Done.

bool RunJavaScriptMessage(JavaScriptMessageType type,

const base::string16& message,